Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS-1746: Pagination through Administration > Users #1764

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

areyeslo
Copy link
Collaborator

Fixed an issue where the Users component was re-rendering multiple times, negatively impacting pagination performance. The root cause was that defaultSortModel variable was updating its reference in memory on each render.

Applied memoization to prevent unnecessary updates and re-renders, ensuring stable pagination behavior:
image

Story

Copy link

github-actions bot commented Jan 21, 2025

Frontend Test Results

  1 files  ±0  125 suites  ±0   46s ⏱️ -1s
436 tests ±0  416 ✅ ±0  20 💤 ±0  0 ❌ ±0 
438 runs  ±0  418 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 4aa43d3. ± Comparison against base commit 201879b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 21, 2025

Backend Test Results

515 tests  ±0   515 ✅ ±0   1m 53s ⏱️ +6s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 4aa43d3. ± Comparison against base commit 201879b.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@areyeslo areyeslo merged commit 7f74bdc into release-0.2.0 Jan 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants