24041 Fix alteration of company type issues #3071
Conversation
| 'numberedLegalNameSuffix': 'B.C. COMMUNITY CONTRIBUTION COMPANY LTD.', | ||
| 'numberedLegalNameSuffix': 'B.C. COMMUNITY CONTRIBUTION COMPANY', |
There was a problem hiding this comment.
@leodube-aot did you confirm this with BA, if yes can you update here (https://github.com/bcgov/lear/blob/main/colin-api/src/colin_api/models/business.py#L86) as well?
Note: You need to redeploy entity-filer after merging this PR to reflect this change while creating a new business
There was a problem hiding this comment.
Actively getting confirmation on this (I meant to mark this PR as draft while I await a response). The issue is a discrepancy between this validation and business-edit-ui. Will be updating shortly.
There was a problem hiding this comment.
Talked to Dylan and the preference is to use "COMMUNITY CONTRIBUTION COMPANY LTD." suffix for numbered companies. Reverted this change and created this PR in edit-ui. Fixing unit tests now and will mark as ready for review.
|
Issue #: /bcgov/entity#24041
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).