update tests, add tsconfig module

bcgov · Feb 21, 2024 · 3ed0943 · 3ed0943
1 parent 50dba71
commit 3ed0943
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 35 deletions.
diff --git a/services/common/src/components/common/Map.tsx b/services/common/src/components/common/Map.tsx
@@ -1,8 +1,7 @@
 import { Skeleton } from "antd";
 import React, { FC, Suspense } from "react";
-import LeafletMap from "./LeafletMap";
 
-// const LeafletMap = React.lazy(() => import("./LeafletMap"));
+const LeafletMap = React.lazy(() => import("./LeafletMap"));
 
 interface MapProps {
   controls: boolean;

diff --git a/services/common/src/components/reports/__snapshots__/ReportDetailsForm-edit.spec.tsx.snap b/services/common/src/components/reports/__snapshots__/ReportDetailsForm-edit.spec.tsx.snap
@@ -72,7 +72,7 @@ exports[`ReportDetailsForm renders edit mode properly 1`] = `
               <label
                 class="ant-form-item-required"
                 for="VIEW_EDIT_REPORT_mine_report_definition_guid"
-                title="Report Name"
+                title=""
               >
                 Report Name
               </label>
@@ -242,7 +242,7 @@ exports[`ReportDetailsForm renders edit mode properly 1`] = `
               <label
                 class="ant-form-item-required"
                 for="VIEW_EDIT_REPORT_description_comment"
-                title="Report Title and Additional Comment"
+                title=""
               >
                 Report Title and Additional Comment
               </label>
@@ -325,7 +325,7 @@ exports[`ReportDetailsForm renders edit mode properly 1`] = `
               <label
                 class="ant-form-item-required"
                 for="VIEW_EDIT_REPORT_submission_year"
-                title="Report Compliance Year/Period"
+                title=""
               >
                 Report Compliance Year/Period
               </label>
@@ -416,7 +416,7 @@ exports[`ReportDetailsForm renders edit mode properly 1`] = `
               <label
                 class="ant-form-item-required"
                 for="VIEW_EDIT_REPORT_due_date"
-                title="Due Date"
+                title=""
               >
                 Due Date
               </label>
@@ -507,7 +507,7 @@ exports[`ReportDetailsForm renders edit mode properly 1`] = `
               <label
                 class="ant-form-item-required"
                 for="VIEW_EDIT_REPORT_submitter_name"
-                title="Submitter Name"
+                title=""
               >
                 Submitter Name
               </label>

diff --git a/services/common/tsconfig.json b/services/common/tsconfig.json
@@ -20,6 +20,7 @@
     "declaration": false /* Generate .d.ts files from TypeScript and JavaScript files in your project. */,
     "declarationMap": true,
     "declarationDir": "dist",
+    "module": "ESNext",
     "moduleResolution": "node",
     "sourceMap": true,
     "allowJs": true /* Allow JavaScript files to be a part of your program. Use the 'checkJS' option to get errors from these files. */,

diff --git a/...omponents/Forms/projects/projectSummary/__snapshots__/AuthorizationsInvolved.spec.js.snap b/...omponents/Forms/projects/projectSummary/__snapshots__/AuthorizationsInvolved.spec.js.snap
@@ -61,6 +61,7 @@ exports[`AuthorizationsInvolved renders properly 1`] = `
       </React.Fragment>
     }
     name="mrc_review_required"
+    required={true}
     validate={
       Array [
         [Function],

diff --git a/...ests/components/Forms/projects/projectSummary/__snapshots__/BasicInformation.spec.js.snap b/...ests/components/Forms/projects/projectSummary/__snapshots__/BasicInformation.spec.js.snap
@@ -12,6 +12,7 @@ exports[`BasicInformation renders properly 1`] = `
     id="project_summary_title"
     label="Project title"
     name="project_summary_title"
+    required={true}
     validate={
       Array [
         [Function],
@@ -22,17 +23,8 @@ exports[`BasicInformation renders properly 1`] = `
   <Field
     component={[Function]}
     id="proponent_project_id"
-    label={
-      <React.Fragment>
-        Proponent project tracking ID (optional)
-        <br />
-        <span
-          className="light--sm"
-        >
-          If your company uses a tracking number to identify projects, please provide it here.
-        </span>
-      </React.Fragment>
-    }
+    label="Proponent project tracking ID"
+    labelSubtitle="If your company uses a tracking number to identify projects, please provide it here."
     name="proponent_project_id"
     validate={
       Array [
@@ -43,20 +35,11 @@ exports[`BasicInformation renders properly 1`] = `
   <Field
     component={[Function]}
     id="project_summary_description"
-    label={
-      <React.Fragment>
-        Project overview 
-        <br />
-        <span
-          className="light--sm"
-        >
-           
-          Provide a 2-3 paragraph high-level description of your proposed project.
-        </span>
-      </React.Fragment>
-    }
+    label="Project overview"
+    labelSubtitle="Provide a 2-3 paragraph high-level description of your proposed project."
     minRows={10}
     name="project_summary_description"
+    required={true}
     validate={
       Array [
         [Function],

diff --git a/...rc/tests/components/Forms/projects/projectSummary/__snapshots__/ProjectDates.spec.js.snap b/...rc/tests/components/Forms/projects/projectSummary/__snapshots__/ProjectDates.spec.js.snap
@@ -15,7 +15,7 @@ exports[`ProjectDates renders properly 1`] = `
         <a
           alt="Major Mines Permitting Office"
           href="https://www2.gov.bc.ca/gov/content/industry/mineral-exploration-mining/permitting/major-mines-permitting-office"
-          rel="noreferrer"
+          rel="noopener noreferrer"
           target="_blank"
         >
           Major Mines Office
@@ -30,7 +30,7 @@ exports[`ProjectDates renders properly 1`] = `
   <Field
     component={[Function]}
     id="expected_draft_irt_submission_date"
-    label="When do you anticipate submitting a draft Information Requirements Table? (optional)"
+    label="When do you anticipate submitting a draft Information Requirements Table?"
     name="expected_draft_irt_submission_date"
     placeholder="Please select date"
     validate={
@@ -42,7 +42,7 @@ exports[`ProjectDates renders properly 1`] = `
   <Field
     component={[Function]}
     id="expected_permit_application_date"
-    label="When do you anticipate submitting a permit application? (optional)"
+    label="When do you anticipate submitting a permit application?"
     name="expected_permit_application_date"
     placeholder="Please select date"
     validate={
@@ -54,7 +54,7 @@ exports[`ProjectDates renders properly 1`] = `
   <Field
     component={[Function]}
     id="expected_permit_receipt_date"
-    label="When do you hope to receive your permit/amendment(s)? (optional)"
+    label="When do you hope to receive your permit/amendment(s)?"
     name="expected_permit_receipt_date"
     placeholder="Please select date"
     validate={
@@ -66,7 +66,7 @@ exports[`ProjectDates renders properly 1`] = `
   <Field
     component={[Function]}
     id="expected_project_start_date"
-    label="When do you anticipate starting work on this project? (optional)"
+    label="When do you anticipate starting work on this project?"
     name="expected_project_start_date"
     placeholder="Please select date"
     validate={