Skip to content

Commit

Permalink
Fix common package dependencies, ignore whitespace changes
Browse files Browse the repository at this point in the history
  • Loading branch information
simensma-fresh committed Dec 17, 2024
1 parent 11bf13c commit 93bc9cd
Show file tree
Hide file tree
Showing 10 changed files with 256 additions and 259 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr.checks.compare.common.folders.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v1
- name: compare-folders
run: |
diff -r -C 5 services/core-web/common services/minespace-web/common
diff -b -r -C 5 services/core-web/common services/minespace-web/common
if [ $? != 0 ]
then
echo "'/services/core-web/common' does not match '/services/minespace-web/common'"
Expand Down
11 changes: 7 additions & 4 deletions services/core-web/common/components/PartyAppointmentTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,13 @@ import {
updatePartyRelationship,
fetchPartyRelationships,
} from "@mds/common/redux/actionCreators/partiesActionCreator";
import { MINISTRY_ACKNOWLEDGED_STATUS, PARTY_APPOINTMENT_STATUS } from "@mds/common/constants/strings";
import TailingsContext from "./tailings/TailingsContext";
import DocumentLink from "@/components/common/DocumentLink";
import CoreTable from "@mds/common/components/common/CoreTable";
import {
MINISTRY_ACKNOWLEDGED_STATUS,
PARTY_APPOINTMENT_STATUS,
} from "@mds/common/constants/strings";

const propTypes = {
columns: PropTypes.arrayOf(PropTypes.string),
Expand All @@ -33,9 +36,9 @@ const PartyAppointmentTable = (props) => {

const [loadingField, setLoadingField] = useState({});

const ministryAcknowledgedColumns = Object.entries(
MINISTRY_ACKNOWLEDGED_STATUS
).map(([value, label]) => ({ value, label }));
const ministryAcknowledgedColumns = Object.entries(MINISTRY_ACKNOWLEDGED_STATUS).map(
([value, label]) => ({ value, label })
);
const statusColumns = Object.entries(PARTY_APPOINTMENT_STATUS).map(([value, label]) => ({
value,
label,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import React, { FC } from "react";

import DocumentTable from "@mds/common/components/documents/DocumentTable";
import { Alert, Button, Form, Typography } from "antd";
import { MineDocument } from "@mds/common/models/documents/document";
import { IMineDocument } from "@mds/common/interfaces";
import { MineDocument } from "@mds/common/models/documents/document";

interface ArchiveDocumentModalProps {
documents: IMineDocument[];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,7 @@ export const EngineerOfRecord: FC<EngineerOfRecordProps> = (props) => {

const daysToEORExpiry =
currentEor?.end_date &&
moment(currentEor.end_date)
.startOf("day")
.diff(moment().startOf("day"), "days");
moment(currentEor.end_date).startOf("day").diff(moment().startOf("day"), "days");

// Enable editing of the EoR when a new EoR party has been selected (party_guid is set),
// but it has yet to be assigned to the TSF (mine_party_appt_guid is not set).
Expand Down
Loading

0 comments on commit 93bc9cd

Please sign in to comment.