[FIX] Inefficient selectors (#3359)

Fix spread inefficiency
bcgov · Jan 6, 2025 · a59efe5 · a59efe5
1 parent 5c87288
commit a59efe5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/services/common/src/redux/selectors/staticContentSelectors.ts b/services/common/src/redux/selectors/staticContentSelectors.ts
@@ -333,10 +333,8 @@ export const getHSRCMComplianceCodesHash = createSelector([getCurrentComplianceC
     .filter(({ article_act_code }) => article_act_code === "HSRCM")
     .reduce((map, code) => {
       const composedValue = formatComplianceCodeValueOrLabel(code, true);
-      return {
-        [code.compliance_article_id]: composedValue,
-        ...map,
-      };
+        map[code.compliance_article_id] = composedValue;
+        return map;
     }, {})
 );
 

diff --git a/services/common/src/redux/utils/helpers.ts b/services/common/src/redux/utils/helpers.ts
@@ -75,8 +75,12 @@ export const createDropDownList = (
 };
 
 // Function to create a hash given an array of values and labels
-export const createLabelHash = (arr) =>
-  arr.reduce((map, { value, label }) => ({ [value]: label, ...map }), {});
+export const createLabelHash = (arr) => {
+  return arr.reduce((map, { value, label }) => {
+    map[value] = label;
+    return map;
+  }, {});
+};
 
 export const formatTractionDate = (dateString: string) => {
   const year = dateString.slice(0, 4);