[MDS-5431] create new or historical record from one window - in New Flow #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…create-new-or-historical-record-from-one-window
isuru-aot
requested review from
matbusby-fw,
taraepp,
simensma-fresh,
henryoforeh-dev and
asinn134
taraepp
reviewed
Oct 11, 2023
services/core-web/src/components/Forms/ExplosivesPermit/ExplosivesPermitForm.tsx
Outdated
Show resolved
Hide resolved
taraepp
reviewed
Oct 11, 2023
services/core-web/src/components/Forms/ExplosivesPermit/ExplosivesPermitFormNew.tsx
Outdated
Show resolved
Hide resolved
matbusby-fw
reviewed
Oct 11, 2023
| return ( | ||
| isFeatureEnabled(Feature.ONE_WINDOW_FOR_CREATING_NEW_OR_HISTORICAL_ESUP) && parentView ? ( |
There was a problem hiding this comment.
While it doesn't hurt anything to have this included here as well as the ExplosivesPermitFormNew, Once it's live we'll eventually be deleting this file (and renaming the new one to this name), so it won't provide much benefit.
There was a problem hiding this comment.
Agreed. Only thing is, with this both changes (5353 & 5431) can be controlled using two different flags.
WDYT? Removing this and controlled both features through one flag is better?
There was a problem hiding this comment.
I lean towards a single flag since it's all part of the same feature that will be released as a whole.
There was a problem hiding this comment.
Applied the changes needed for this. Please verify.
asinn134
previously approved these changes
Oct 11, 2023
… records (#2715) * adding soft deletion of now_application_document_identity_xref * adding soft delete in now_submissions document table * adding document.deleted_ind check for false in now_app * filtering out now_submission docs with deleted_ind equal true * adding deleted_ind check to submission_documents secondary join * removing space change * removing space change * removing space change
henryoforeh-dev
previously approved these changes
Oct 12, 2023
remove update on issue date.
…d functionality (#2714) * Refactor Explosives Permit Form for better readability and functionality The code refactor has mainly focused on the `MagazineFormNew.tsx` and `ExplosivesPermitFormNew.tsx` components. Unnecessary `Form.Item` wrappers have been removed, resulting in cleaner code and more readable form fields. Ability to remember and set active panel for the Collapse element in the MagazineForm has been added which will enhance user experience as users will no longer lose their panel selections after a page reload. In the `ExplosivesPermitFormNew.tsx`, the form name has been made more descriptive and specific (EXPLOSIVES_PERMIT_NEW). Also, removed unused 'bindActionCreators and change' import to enhance performance. All these changes were made based on PR review comments. * made delete button clickable * fixed a couple of file errors * remove broken validation * restored Tara's work
* switched compare function to moment from native Date so that 2023-02-15 does not become 2023-02-14 at 6pm local time * [MDS-5337] Use artifactory to cache fontawesome pacakges * Updated yarn.lock * Fixed react type errors --------- Co-authored-by: Tara Epp <[email protected]>
…cated (#2717) * [MDS-5337] Use artifactory to cache fontawesome pacakges * Updated yarn.lock * Fixed react type errors * MDS-5537 Unset old fontawesome token config
…w' of https://github.com/bcgov/mds into mds-5431-create-new-or-historical-record-from-one-window
isuru-aot
dismissed stale reviews from matbusby-fw, henryoforeh-dev, and asinn134
via
68cc32e
|
Create a separate PR for this. #2720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-5431
Why are you making this change? Provide a short explanation and/or screenshots
This is part of the PR-2708. With this change the same flow is enabled in the new flow (when the
esup_permit_amendmentfeature is enabled).