Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5515] SchemaSpy updates #2718

Merged
merged 15 commits into from
Oct 20, 2023
Merged

[MDS-5515] SchemaSpy updates #2718

merged 15 commits into from
Oct 20, 2023

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Oct 12, 2023

Objective

  • restart the schemaspy deployment in openshift so that new pods are created with updated info
  • have it be automatic so we don't have to do it manually
    • tied it into core-api deploys
  • it's not identical (doesn't run flyway first), but I setup a temporary workflow to run on PR to make sure it can run (will delete once verified) <-- DELETED, verified that reusable workflow is called successfully
  • attempted to fix the run-if-failed in the core-api deployment workflows. Based on SO answer found here https://stackoverflow.com/questions/71430668/how-to-run-a-github-actions-job-on-workflow-failure by Yann Thomas-Gérard
    • if one of those executes sometime for us we can put it in other places

MDS-5515

Why are you making this change? Provide a short explanation and/or screenshots

@@ -77,8 +82,8 @@ jobs:

run-if-failed:
runs-on: ubuntu-20.04
needs: [trigger-gitops]
if: always() && (needs.trigger-gitops.result == 'failure')
needs: [build-backend, build-flyway, trigger-gitops]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specifically didn't put schemaspy-rollout in here because this notification will say that core-api didn't deploy, and schemaspy has its own notification anyway


on:
workflow_call:
workflow_dispatch:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to be able to use workflow_call to have it be triggered from another workflow, and workflow_dispatch, so we can call it manually. Only needed separate files for each to allow manual calls.

@taraepp taraepp added 🏭 CI/CD This pull request includes CI/CD changes. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💊 Fix Fixes something that isn't working :) labels Oct 19, 2023
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice yaml-ing

@taraepp taraepp merged commit a2f5af5 into develop Oct 20, 2023
6 checks passed
@taraepp taraepp deleted the mds-5515-schemaspy-ci branch October 20, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏭 CI/CD This pull request includes CI/CD changes. 💊 Fix Fixes something that isn't working :) 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants