-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS-5349] - Core ESUP amendment changes table #2730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a feature to show the history of amendments in an Explosives Permit. This feature provides a clear way to track changes and the reasons for the modifications in the permit overtime. Updates were made in respective models, interfaces and file structures. Code enhancement also includes providing table views and detailed comparisons of permits history for each amendment. This assists users to see differences between various versions of permit and understand the changes that were made. User interface was also improved to allow better navigation.
matbusby-fw
added
💾 Backend
This pull request includes backend changes.
💻 Frontend
This pull request includes frontend changes.
⌨️ Typescript
This pull request includes Typescript changes
labels
Oct 17, 2023
matbusby-fw
requested review from
henryoforeh-dev,
taraepp,
simensma-fresh and
isuru-aot
October 17, 2023 23:00
matbusby-fw
added
the
👍 Ready for review
Pull request has been double checked by the author and is ready for comments and feedback.
label
Oct 17, 2023
henryoforeh-dev
previously approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean!
taraepp
reviewed
Oct 18, 2023
@@ -37,7 +37,7 @@ function loadExternalSecrets() { | |||
echo -e "Make sure you download the OpenShift cli binary (oc) from https://github.com/openshift/okd/releases ?" | |||
|
|||
if [ "$CODESPACES" = "true" ]; then | |||
echo -e "${bold}Do you want to download and install oc? (only accepts 'yes')${normal}" | |||
echo -e "${bold}Do you want to download and install oc? (answering anything except 'yes' will bypass this step)${normal}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES.
taraepp
previously approved these changes
Oct 18, 2023
matbusby-fw
dismissed stale reviews from taraepp and henryoforeh-dev
via
October 18, 2023 21:50
c54cb37
taraepp
previously approved these changes
Oct 18, 2023
taraepp
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💾 Backend
This pull request includes backend changes.
💻 Frontend
This pull request includes frontend changes.
⌨️ Typescript
This pull request includes Typescript changes
👍 Ready for review
Pull request has been double checked by the author and is ready for comments and feedback.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-5349