Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5349] - Core ESUP amendment changes table #2730

Merged
merged 8 commits into from
Oct 18, 2023

Conversation

matbusby-fw
Copy link
Collaborator

  • Some cleanup of the esup view modal
  • altered BE to return amendments along with initial permit
  • created modal to show the differences between each version of the explosives permit

Objective

MDS-5349

image image image

Added a feature to show the history of amendments in an Explosives Permit. This feature provides a clear way to track changes and the reasons for the modifications in the permit overtime. Updates were made in respective models, interfaces and file structures. Code enhancement also includes providing table views and detailed comparisons of permits history for each amendment. This assists users to see differences between various versions of permit and understand the changes that were made. User interface was also improved to allow better navigation.
@matbusby-fw matbusby-fw added 💾 Backend This pull request includes backend changes. 💻 Frontend This pull request includes frontend changes. ⌨️ Typescript This pull request includes Typescript changes labels Oct 17, 2023
@matbusby-fw matbusby-fw added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Oct 17, 2023
Copy link
Contributor

@henryoforeh-dev henryoforeh-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean!

@@ -37,7 +37,7 @@ function loadExternalSecrets() {
echo -e "Make sure you download the OpenShift cli binary (oc) from https://github.com/openshift/okd/releases ?"

if [ "$CODESPACES" = "true" ]; then
echo -e "${bold}Do you want to download and install oc? (only accepts 'yes')${normal}"
echo -e "${bold}Do you want to download and install oc? (answering anything except 'yes' will bypass this step)${normal}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES.

taraepp
taraepp previously approved these changes Oct 18, 2023
@matbusby-fw matbusby-fw dismissed stale reviews from taraepp and henryoforeh-dev via c54cb37 October 18, 2023 21:50
taraepp
taraepp previously approved these changes Oct 18, 2023
@matbusby-fw matbusby-fw merged commit 480a266 into develop Oct 18, 2023
11 checks passed
@matbusby-fw matbusby-fw deleted the mds-5349-diff-table branch October 18, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💾 Backend This pull request includes backend changes. 💻 Frontend This pull request includes frontend changes. ⌨️ Typescript This pull request includes Typescript changes 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants