Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5553] (and 5542) Request a connection invitation for a permitee #2743

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Oct 25, 2023

Original PR: #2732

Objective

MDS-5553
MDS-5542

A Minespace proponent would like to establish a digital wallet connection between MDS (traction) and the mining companies digital wallet.

This PR introduces functionality that allows a Minespace proponent to generate out-of-band with no payloads for the purposes of connecting two hyperledger aries agents. BC Digital Trust Services hosts Traction, a multi-tenanted service that is hosting the wallet for the 'Chief Permitting Officer of Mines' that needs to connection with the wallets of mining companies for the purpose of issuing Mines Act Permit as a verifiable credential.

Remaining TODOs, I am not an expert in React, so please comment if i have done anything unexpected.

I need help on these:

  • Fix bug where actionCreator is called continuously as long as modal is open, it should only activate on button
  • Loading animation while waiting for invitation response
  • Feature Flag the frontend

These I can do, but wanted to make the PR early:

  • Add restriction that 'Connection Info' button is only available for Major Mines
  • Add restriction that permit is open
  • If there is an active connection, indicate that and do not allow a new invitation to be created
  • "Issue Digital Credential" is only visible if there is an active connection,

Jsyro and others added 2 commits October 25, 2023 13:17
…2732)

* better help text.

* API serves current_permittee_guid

* untested action creator

* permitee column, invitation request made successfully on modal load

* show invitation url on the screen

actionCreator is being called over and over again.

* sync common folders

* convert action creator to typescript

* only show button if mine is major mine

* add get vc invtitations endpoint, permit must be open\

* fixes

* typescript updates by Tara!

* skeleton loading by Tara

* add feature flag

* api now returns connection status with current_permitee

* pass state up to form

* pass connectionState and remove logging

* don't show button if active

* remove not working button

* don't allow null, replace with string

* common folder diff

* feature flag and remove unused import

Signed-off-by: Jason Syrotuck <[email protected]>

---------

Signed-off-by: Jason Syrotuck <[email protected]>
Copy link
Collaborator

@Jsyro Jsyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review doesn't count! I think this PR is pretty great.

@taraepp taraepp merged commit 73715a6 into develop Oct 25, 2023
11 checks passed
@taraepp taraepp deleted the mds-5553-vc branch October 25, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants