[MDS-5586] - ESUP documents #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…view documents in viewmodal fix.
matbusby-fw
commented
Oct 27, 2023
| create_issued_permit() | ||
|
|
||
| # If the permit documents have not already been generated, generate them. | ||
| if not self.mine_documents: |
There was a problem hiding this comment.
still not the best control on this, but it's more robust than it was. Will bring this up in SU as a business rule to consider (When to generate the docs)
henryoforeh-dev
approved these changes
Oct 27, 2023
isuru-aot
approved these changes
Oct 27, 2023
taraepp
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where ESUP generated documents were being generated every time the esup was updated
Fixed issue where supporting documents were not being saved to the ESUP
Fixed conditional statements to properly display the documents in the view modal.
Objective
MDS-5586