[MDS-5505] e2e test major projects refactor #2780
Conversation
henryoforeh-dev
requested review from
matbusby-fw,
taraepp,
isuru-aot,
asinn134 and
simensma-fresh
|
|
||
| cy.get('[data-cy="home-link-button-major-projects"]', { timeout: 5000 }).click({ force: true }); | ||
| cy.get('[data-cy="home-link-button-major-projects"]', { timeout: 10000 }).click({ force: true }); |
There was a problem hiding this comment.
one thing- is this running 2 separate tests, the first which uploads the file and the second which downloads? If so, would it be faster to run it as one test that uploads and then downloads, taking out the login and navigation in the middle? I know that unit-test thinking promotes making tests smaller and independent, but cypress recommends combining pieces of the process into a longer one to enhance performance.
There was a problem hiding this comment.
Combined the 2 tests into one to enhance performance.
| cy.get('input[type="file"]').attachFile({ | ||
| fileContent: fileContent, | ||
| fileName: fileName, | ||
| mimeType: 'application/pdf', |
There was a problem hiding this comment.
Did eslint not catch this file for formatting?
There was a problem hiding this comment.
Updated to allow eslint to reformat. My frontend git tool had no verify checked all the while.
Objective
MDS-5505