[MDS-5473] Fix esup amendment letter #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryoforeh-dev
requested review from
matbusby-fw,
isuru-aot,
asinn134,
simensma-fresh and
taraepp
taraepp
reviewed
Nov 17, 2023
.../core-api/app/api/mines/explosives_permit_amendment/resources/explosives_permit_amendment.py
Outdated
Show resolved
Hide resolved
matbusby-fw
reviewed
Nov 17, 2023
simensma-fresh
previously approved these changes
Nov 20, 2023
taraepp
approved these changes
Nov 20, 2023
isuru-aot
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-5473
This pull request (PR) focuses on implementing the functionality for issuing ESUP amendment letters and certificates. In the previous PR, I had only implemented the functionality to preview the letter and certificate for ESUP amendments.
I also added a missing action type constant for verifiable credentials that was causing build errors locally