[MDS-5583] View Report #2885
Merged
[MDS-5583] View Report #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t record on that page. Already had the endpoint there, but no 'get' of a single record. Made a couple files typescript. Make the link to the new page from the 'view' on the table
…itialValues for the form, pass them in. Update Callout to tsx
… edit with initialValues
… picking the previous year, pass the right form values to ReportFilesTable, do submission handling on the ReportPage
…y of mine reports, too) and give some initial values to view report form to test that all out
taraepp
requested review from
simensma-fresh,
henryoforeh-dev,
matbusby-fw,
isuru-aot and
asinn134
| @@ -38,6 +46,12 @@ const reportReducerObject = { | |||
| export const getReports = (state) => state[REPORTS].reports; | |||
| export const getReportsPageData = (state) => state[REPORTS].reportsPageData; | |||
| export const getMineReports = (state) => state[REPORTS].mineReports; | |||
| export const getMineReportById = (state, reportGuid) => { | |||
There was a problem hiding this comment.
Is this function used to get the latest report or the first report ?
There was a problem hiding this comment.
it is meant to get the whole report, including all submissions.
| useEffect(() => { | ||
| if (!mine || mine.mine_guid !== mineGuid) { | ||
| dispatch(fetchMineRecordById(mineGuid)); | ||
| } |
There was a problem hiding this comment.
Can the logic here can be moved to the other useEffect on line 38 since the useEffect gets triggered when either reportGuid or mineGuid changes ?
There was a problem hiding this comment.
hmm, yeah, I think I can. 👍
simensma-fresh
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
NOTE: report type & report name are a bit broken right now. This is expected and there's another ticket where this should be handled (5662 I think?)
MDS-5583