Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5818] CRR Cleanup #2975

Merged
merged 4 commits into from
Mar 1, 2024
Merged

[MDS-5818] CRR Cleanup #2975

merged 4 commits into from
Mar 1, 2024

Conversation

matbusby-fw
Copy link
Collaborator

Objective

MDS-5818

  • Updated the wording of the toast message when a user updates a report vs a newly created one
  • Added PRR reports to a second table on Minespace (below CRRs on the same page)
  • Fixed a bug where the view screen for a report would have blank values if the user had just backed out of creating a new report
image

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@matbusby-fw matbusby-fw added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Mar 1, 2024
@matbusby-fw matbusby-fw merged commit 19df0fd into develop Mar 1, 2024
18 of 20 checks passed
@matbusby-fw matbusby-fw deleted the mds-5818-crr-cleanup branch March 1, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants