[MDS-5801] Text/Language updates #2976
Conversation
…e 'view accepted filetypes' and contact us email
…s easier to find, made maximum charachters mandatory in RenderAutoSizeField, tweaked logic of the label for file upload, fixed a couple issues in CORE
| @@ -62,8 +62,8 @@ import { WrappedFieldProps, WrappedFieldMetaProps, WrappedFieldInputProps } from | |||
| export interface BaseInputProps extends WrappedFieldProps { | |||
| meta: WrappedFieldMetaProps; | |||
| input: WrappedFieldInputProps; | |||
| label?: string; | |||
| labelSubtitle?: string; | |||
| label?: string | ReactNode; | |||
There was a problem hiding this comment.
pretty much just updating this file to accept elements as well as strings for labels.
| @@ -9,36 +9,19 @@ import { FormConsumer, IFormContext } from "./FormWrapper"; | |||
|
|
|||
| interface AutoSizeProps extends BaseInputProps { | |||
| minRows?: number; | |||
| maximumCharacters?: number; | |||
| maximumCharacters: number; | |||
There was a problem hiding this comment.
I decided that this should be mandatory. There's no instances where this version of the component (ie the one in common) is used and the value is not supplied.
| @@ -56,7 +57,7 @@ export const RenderSelect: FC<SelectProps> = ({ | |||
| (meta.warning && <span>{meta.warning}</span>)) | |||
| } | |||
| id={id} | |||
| getValueProps={() => ({ value: input.value })} | |||
| getValueProps={() => input.value !== "" && { value: input.value }} | |||
There was a problem hiding this comment.
placeholder wasn't showing because I think redux was supplying it with "" when it was empty.
| @@ -27,4 +28,55 @@ | |||
|
|
|||
| .has-error .ant-checkbox-group:not([disabled]):hover { | |||
| border-color: #ff4d4f; | |||
| } | |||
|
|
|||
| // FORMS | |||
There was a problem hiding this comment.
was having a hard time deciding when to put things in antd-overrides and when to put them in Forms, so just moved over from overrides to the more specific file.
There was a problem hiding this comment.
In the future, might want to think about implementing some common styles, especially for basic layout type stuff.
…some icons in buttons
|
|
|
taraepp
requested review from
simensma-fresh,
matbusby-fw,
asinn134 and
isuru-aot
Objective
MDS-5801
Why are you making this change? Provide a short explanation and/or screenshots
all a bit zoomed out
MS Getting Started CRR
MS Getting Started PRR
MS Report Details Form (PRR) - top
MS Report Details Form (both) - bottom
MS Report Details Form (CRR) - top (1.10.7.2 has no More Info link)
Core Getting Started CRR
Core Getting Started PRR
Core Report Details (PRR) - top
Core Report Details (both) - bottom
Core Report Details (CRR) - top