-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS-5792] status codes and banners #2984
Conversation
# Conflicts: # services/common/src/constants/enums.ts # services/common/src/constants/strings.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the submission rather than creating a new one loses the audit trail. I do think that a new submission should be created in this case.
I thought creating a new status was out of the scope of this ticket. |
Can just use the the existing createReportSubmission functions to track the history. Much simpler to implement. |
...ces/core-web/src/tests/components/modalContent/UpdateMineReportSubmissionStatusModal.spec.js
Outdated
Show resolved
Hide resolved
Updated as advised. |
Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'Failed conditions |
Quality Gate failed for 'bcgov-sonarcloud_mds_common'Failed conditions |
Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'Issues Measures |
Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'Failed conditions |
Objective
MDS-5792