Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5792] status codes and banners #2984

Merged
merged 13 commits into from
Mar 6, 2024

Conversation

henryoforeh-dev
Copy link
Contributor

@henryoforeh-dev henryoforeh-dev commented Mar 5, 2024

Objective

MDS-5792

  • Created / Updated new banners to reflect status codes according to design.
  • Implemented functionality to update status code for mine report submission.
  • Commented code for saving Additional Comment.

image

image

image

@henryoforeh-dev henryoforeh-dev marked this pull request as draft March 5, 2024 17:38
@henryoforeh-dev henryoforeh-dev marked this pull request as ready for review March 5, 2024 17:38
# Conflicts:
#	services/common/src/constants/enums.ts
#	services/common/src/constants/strings.tsx
Copy link
Collaborator

@taraepp taraepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the submission rather than creating a new one loses the audit trail. I do think that a new submission should be created in this case.

@henryoforeh-dev
Copy link
Contributor Author

Updating the submission rather than creating a new one loses the audit trail. I do think that a new submission should be created in this case.

I thought creating a new status was out of the scope of this ticket.

@taraepp
Copy link
Collaborator

taraepp commented Mar 6, 2024

Updating the submission rather than creating a new one loses the audit trail. I do think that a new submission should be created in this case.

I thought creating a new status was out of the scope of this ticket.

Can just use the the existing createReportSubmission functions to track the history. Much simpler to implement.

@henryoforeh-dev
Copy link
Contributor Author

henryoforeh-dev commented Mar 6, 2024

Updating the submission rather than creating a new one loses the audit trail. I do think that a new submission should be created in this case.

I thought creating a new status was out of the scope of this ticket.

Can just use the the existing createReportSubmission functions to track the history. Much simpler to implement.

Updated as advised.

Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@henryoforeh-dev henryoforeh-dev merged commit 226260b into develop Mar 6, 2024
17 of 20 checks passed
@henryoforeh-dev henryoforeh-dev deleted the MDS-5792-banner-clarification branch March 6, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants