[MDS-5833] allow reissuance after revocation #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data type issue
henryoforeh-dev
previously approved these changes
Mar 26, 2024
henryoforeh-dev
previously approved these changes
Mar 26, 2024
taraepp
reviewed
Mar 26, 2024
| @@ -4,6 +4,9 @@ import CustomAxios from "@mds/common/redux/customAxios"; | |||
| import { ENVIRONMENT, MINES_ACT_PERMITS_VC_LIST } from "@mds/common/constants"; | |||
| import * as API from "@mds/common/constants/API"; | |||
| import { RootState } from "@mds/common/redux/rootState"; | |||
| import { DataSourceItemType } from "antd/lib/auto-complete"; | |||
| import { debug } from "webpack"; | |||
| import { a } from "@mds/common/tests/mocks/dataMocks"; | |||
|
|
|||
There was a problem hiding this comment.
What is 'a'? And is this + debug something that's no longer being used? I would guess it might cause issues with variables on sort(a,b)
|
|
|
|
henryoforeh-dev
approved these changes
Mar 26, 2024
taraepp
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-5833
Active and valid
Immediately after revoked (not available for re-issuance)
Revoked but made available to second issuance
Other Changes:
Objects modified by webhooks have a timestamp of the webhooks. this will mean if packets are received in the wrong order a newer state will not be overriden by an older state because the packets arrived in the reverse order.