[MDS-5658] Fixing previous mine manager issue #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taraepp
reviewed
Mar 27, 2024
| @@ -1,4 +1,5 @@ | |||
| import uuid | |||
| from datetime import datetime, timezone | |||
There was a problem hiding this comment.
minor, but are these new imports being used?
There was a problem hiding this comment.
Ah, good catch. I love cleaning up unused imports! Otherwise this looks great Isuru!
There was a problem hiding this comment.
Removed unused imports :)
|
matbusby-fw
approved these changes
Mar 27, 2024
taraepp
approved these changes
Mar 27, 2024
simensma-fresh
pushed a commit
that referenced
this pull request
Jun 12, 2024
* fixing previous mine manager retrieval * updating unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-5658
Why are you making this change? Provide a short explanation and/or screenshots
Below is a screenshot of PROD data (Second row is the valid manager), where mine-managers are exist without end_date + without status. Hence raising this PR to get the correct mine manager.
