Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5811] gis_export_view migration #3033

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

matbusby-fw
Copy link
Collaborator

Objective

MDS-5811

  • Added mine_purpose, regional_contact and latest_response_date to the gis_export materialized view
  • Manually added this migration to the flyway history for dev and test to prevent it running there
  • Updated the gis model in the backend to accomodate the new fields

henryoforeh-dev
henryoforeh-dev previously approved these changes Apr 3, 2024
Copy link
Contributor

@henryoforeh-dev henryoforeh-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

END IF;
END $$;

CREATE MATERIALIZED VIEW public.now_application_gis_export_view
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to make sure but is the only change in the big query just adding the new fields?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Just adding the new columns as required.

henryoforeh-dev
henryoforeh-dev previously approved these changes Apr 3, 2024
asinn134
asinn134 previously approved these changes Apr 3, 2024
@matbusby-fw matbusby-fw dismissed stale reviews from asinn134 and henryoforeh-dev via 19c0fc2 April 4, 2024 15:55
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@henryoforeh-dev henryoforeh-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker!

@matbusby-fw matbusby-fw merged commit bdcf950 into develop Apr 4, 2024
12 checks passed
@matbusby-fw matbusby-fw deleted the mds-5811-add-fields-to-gis-export branch April 4, 2024 16:29
simensma-fresh pushed a commit that referenced this pull request Jun 12, 2024
* added migration for gis materialized view and updated model

* update drop matview query

* created sql-prod migration folder and set it to only run in prod environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants