[MDS-5712] AMS Application Purpose #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in Callour, GroupCheckbox
…stly match mockup
…ows, add new columns
…en received on the FE, and update the form accordingly. Fix some validation, radio button, checkbox label that is a form section issues
…, transform payload on FE
… and 'MINES ACT PERMIT' UI according to AC/mockups, make the list of checkboxes be validated
…date authorization interface, update data mocks
…ving on CORE, and bug on new records
taraepp
commented
Apr 4, 2024
| elif authorization.get('project_summary_authorization_type') == 'OTHER': | ||
| v = Validator(other_schema, purge_unknown=True) | ||
|
|
||
| if not v.validate(authorization): |
There was a problem hiding this comment.
The errors aren't terribly pretty (by default...) but they get the job done. I found it easier to use this than to do all the if's and len's and not in's I'd be doing otherwise. It's not specific about which authorization is causing the issue, for the reason that I didn't want to cause a 500 trying to get an attribute that may be causing the 400, so just logged the whole record on the BE if it's invalid.
Documentation: https://docs.python-cerberus.org/validation-rules.html
…authorization description
|
|
|
|
matbusby-fw
reviewed
Apr 5, 2024
| import { BaseInputProps, getFormItemLabel } from "./BaseInput"; | ||
|
|
||
| /** | ||
| * Just can't conform the UI to play nice with redux-form? |
There was a problem hiding this comment.
😆 Love it. Reminds me of an infomercial. "Has this ever happened to you!?"
henryoforeh-dev
approved these changes
Apr 5, 2024
matbusby-fw
approved these changes
Apr 5, 2024
asinn134
reviewed
Apr 5, 2024
| other_types text[]; | ||
| type_count integer; | ||
| delete_guids uuid[]; | ||
| BEGIN |
There was a problem hiding this comment.
Nice work with the sql scrip here 👍
asinn134
approved these changes
Apr 5, 2024
simensma-fresh
pushed a commit
that referenced
this pull request
Jun 12, 2024
* change around authorizations involved, convert to TS, fix some issues in Callout, GroupCheckbox * add 'help' text to radio buttons, make authorizations form section mostly match mockup * make field names closer to mappings, tooltip * migration to separate out AMS amended authorizations into their own rows, add new columns * update BE response to include new fields, format a bit differently when received on the FE, and update the form accordingly. Fix some validation, radio button, checkbox label that is a form section issues * fix issue with label and with radio buttons, process & validate on BE, transform payload on FE * move authorizations involved into common, put in CORE, change 'OTHER' and 'MINES ACT PERMIT' UI according to AC/mockups, make the list of checkboxes be validated * make a hidden field component to handle most of the redux-y stuff, update authorization interface, update data mocks * fix style issues on CORE * fix issues with multiselect changing value onBlur, fix issues with saving on CORE, and bug on new records * add loading indicator on multiselect, remove console log, snaps * remove failing line from cypress test * fill in an authorization for cypress test * make required fields consistent and also don't show an empty item in multiselect * rename migration for order, and update data with 'OTHER' type to use authorization description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-5712
Why are you making this change? Provide a short explanation and/or screenshots
This is what it looks like when one of the required fields is missing on the BE:
Tech debt: