Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] BE condition to check AMS terms agreed #3056

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Apr 18, 2024

Objective

  • condition was incorrect on whether to check if "ams_terms_agreed" box was checked- was looking for None when it should have been looking for data shaped like {amendments: [], new: []}
  • BE test to match

MDS-5844

Why are you making this change? Provide a short explanation and/or screenshots

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@taraepp taraepp merged commit 3352133 into develop Apr 18, 2024
11 of 12 checks passed
@taraepp taraepp deleted the fix-project-summary-declaration-submit branch April 18, 2024 18:54
simensma-fresh pushed a commit that referenced this pull request Jun 12, 2024
fix condition for ams terms agreed to match what is sent from FE, plus updates to BE test for this scenario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants