Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6139] Don't disable IRT/final app tab when "Start" button is enabled #3282

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Oct 25, 2024

Objective

  • made a mistake last PR!
  • I kinda forgot that disabling the tab on project overview also effectively disables the start button
  • because it does a query selector to find the tab and does a .click() on it
  • previously, I did try just running the same function from clicking the tab when you click start and it didn't work
  • don't want to spend too much time on that rabbit hole though
  • I went to CORE to make the "View" behaviour more similar (ie: able to click the tab even if button is disabled if summary was submitted) but ended up reverting it because the IRT tab behaviour was VERY confusing (first it crashed until I added that ? and then it showed Loading because loading is dependent on the IRT having a guid and I thought it was a bad idea to play with that logic)

MDS-6139

Why are you making this change? Provide a short explanation and/or screenshots

@taraepp taraepp added the 🚧 WIP This is work in progress code that may change significantly. label Oct 25, 2024
simensma-fresh
simensma-fresh previously approved these changes Oct 25, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
73.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@taraepp taraepp added 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. and removed 🚧 WIP This is work in progress code that may change significantly. labels Oct 25, 2024
@taraepp taraepp merged commit 6ee1bde into develop Oct 25, 2024
13 checks passed
@taraepp taraepp deleted the mds-6139-disabling-bug branch October 25, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants