Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-5697] Add method to forward UNTP DCC's through Orgbook Publisher #3289

Merged
merged 45 commits into from
Nov 6, 2024
Merged

[MDS-5697] Add method to forward UNTP DCC's through Orgbook Publisher #3289

merged 45 commits into from
Nov 6, 2024

Conversation

Jsyro
Copy link
Collaborator

@Jsyro Jsyro commented Oct 30, 2024 •
edited
Loading

Objective

MDS-5697

Implemented both options for now, can be trialed until decision is made there

Option A)

  • MDS creates the UNTP credential, signs it with their own tenant
  • with the CPO keypair
  • and is pushed to Orgbook publisher

Option B)

  • MDS sends abbreviated date to Orgbook publisher
  • Publisher constructs UNTP DCC from fixed templating
  • Publisher signs with a different keypair.
  • Orgbook publisher injects and manages the BitStringStatusList(s).

It would save us from having to manage status lists and align our credentials with others on the service, but this work was already done, so i'm sharing this for now.

Jsyro added 30 commits September 5, 2024 14:11
@Jsyro
attestation type and use published vocab
c1337f5
@Jsyro
need tupe
b4e993b
@Jsyro
update dcc construction and library to dcc 0.3.10
71bf73e
@Jsyro
update test
7ccca5c
@Jsyro
test
c82d290
@Jsyro
remove/update logging
52d8ad3
@Jsyro
ensure query doesn't include regional mines (yet
c731603
@Jsyro
make context files configurable.
5cd78ed 
based on UNTPDCC and BCMinesActPermitCredential versions
@Jsyro
real context extension
996b6f7
@Jsyro
remove type not defined in context files.
429d9f1 
update context reference to 0.5.0
@Jsyro
Merge branch 'develop' into feature/untp-dcc-cleanup
a53415c
@Jsyro
add schema file and config, updated to match 0.1.0 of models package
ae03533
@Jsyro
nullable but not defaulted.
894306c
@Jsyro
same with product
dd076cb
@Jsyro
same for ca
cac3b45
@Jsyro
link to credential, not orgbook identifer.
9b00243
@Jsyro
real tdw registry, and schema extension
f6d72cf
@Jsyro
Merge branch 'develop' into feature/untp-dcc-cleanup
babbf36
@Jsyro
Define verification method, strip did
d4a1ea6 
stop using sovrin did, just use did:web from tdw server.
@Jsyro
add permit_number, remove name.
e10d96d
@Jsyro
extended class needs extended type
a703dcb
@Jsyro
name is required in model (But not in spec)
01fc4f5 
remove hardcode from id path
@Jsyro
bc prefix is removed
583be0b
@Jsyro
vcdm 2.0 updates.
209a9f9 
name is included, issuanceDate is now validFrom.
@Jsyro
update to use new DataIntegrity Proof
01f5e37 
DI proofs are going to be required by orgbook, but maybe not others. removed other WIP code with different endpoints
@Jsyro
merge
08241e7
@Jsyro
remove dup line from merge
f250661
@Jsyro
remove dup lines from merge.
5fb9575
@Jsyro
key 1 is different, signing key is now key-02-multikey
19d8867
@Jsyro
use mine_no ad factility identifier
794d4d1
@Jsyro Jsyro added 🛑 DO NOT MERGE This pull request will have potentially destructive or risky changes if merged. 🚧 WIP This is work in progress code that may change significantly. 💾 Backend This pull request includes backend changes. labels Oct 30, 2024
@Jsyro Jsyro marked this pull request as ready for review October 31, 2024 18:03
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
1 Security Hotspot
29.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jsyro Jsyro added 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. python Pull requests that update Python code and removed 🛑 DO NOT MERGE This pull request will have potentially destructive or risky changes if merged. 🚧 WIP This is work in progress code that may change significantly. labels Nov 4, 2024
taraepp
taraepp approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@taraepp taraepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jsyro Jsyro merged commit d1d60dd into develop Nov 6, 2024
16 of 17 checks passed
@Jsyro Jsyro deleted the feature/untp-dcc-cleanup branch November 6, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taraepp taraepp taraepp approved these changes

@matbusby-fw matbusby-fw matbusby-fw approved these changes

Assignees
No one assigned
Labels
💾 Backend This pull request includes backend changes. python Pull requests that update Python code 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jsyro @matbusby-fw @taraepp