Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6170] Update major project table to reflect project statuses #3303

Merged
merged 11 commits into from
Nov 14, 2024

Conversation

asinn134
Copy link
Collaborator

@asinn134 asinn134 commented Nov 9, 2024

Objective

MDS-6170

  • Updated the all major projects table to give a more accurate view on the status of the project stages. Added ability to expand project row to view a sub table with project stage status info.

  • Removed MRC, Stage, Status columns from the table. Also removed the same from the search filters.

  • Made default order of table to be descending and sorted by updated date.

  • Converted some older JS files to Typescript.

Screenshot (510)

@@ -234,7 +234,7 @@ export const fetchProjectById = (projectGuid: string): AppThunk<Promise<IProject
};

export const fetchProjects = (params: IProjectPageData): AppThunk => (dispatch) => {
const defaultParams = params || Strings.DEFAULT_DASHBOARD_PARAMS;
const defaultParams = params || `${Strings.DEFAULT_DASHBOARD_PARAMS}${Strings.DEFAULT_MAJOR_PROJECTS_DASHBOARD_PARAMS}`;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change in this file

@asinn134 asinn134 marked this pull request as ready for review November 13, 2024 18:23
@asinn134 asinn134 added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Nov 13, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
70.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
78.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
53.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@asinn134 asinn134 requested a review from taraepp November 13, 2024 23:18
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks great!

@asinn134 asinn134 merged commit ad07a9c into develop Nov 14, 2024
15 of 18 checks passed
@asinn134 asinn134 deleted the mds-6170-update-major-project-summary-table branch November 14, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants