-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS-6170] Update major project table to reflect project statuses #3303
[MDS-6170] Update major project table to reflect project statuses #3303
Conversation
@@ -234,7 +234,7 @@ export const fetchProjectById = (projectGuid: string): AppThunk<Promise<IProject | |||
}; | |||
|
|||
export const fetchProjects = (params: IProjectPageData): AppThunk => (dispatch) => { | |||
const defaultParams = params || Strings.DEFAULT_DASHBOARD_PARAMS; | |||
const defaultParams = params || `${Strings.DEFAULT_DASHBOARD_PARAMS}${Strings.DEFAULT_MAJOR_PROJECTS_DASHBOARD_PARAMS}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only change in this file
services/core-web/src/components/Forms/MajorProject/MajorProjectSearchForm.tsx
Outdated
Show resolved
Hide resolved
services/core-web/src/components/dashboard/majorProjectHomePage/MajorProjectSearch.tsx
Outdated
Show resolved
Hide resolved
services/core-web/src/components/dashboard/majorProjectHomePage/MajorProjectTable.tsx
Outdated
Show resolved
Hide resolved
services/core-web/src/components/dashboard/majorProjectHomePage/MajorProjectTable.tsx
Outdated
Show resolved
Hide resolved
services/core-web/src/components/dashboard/majorProjectHomePage/MajorProjectTable.tsx
Outdated
Show resolved
Hide resolved
...ices/core-web/src/tests/components/dashboard/majorProjectHomePage/MajorProjectSearch.spec.js
Outdated
Show resolved
Hide resolved
services/core-web/src/components/dashboard/majorProjectHomePage/MajorProjectTable.tsx
Show resolved
Hide resolved
Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'Issues Measures |
Quality Gate failed for 'bcgov-sonarcloud_mds_common'Failed conditions |
Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'Failed conditions |
Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'Failed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This looks great!
Objective
MDS-6170
Updated the all major projects table to give a more accurate view on the status of the project stages. Added ability to expand project row to view a sub table with project stage status info.
Removed MRC, Stage, Status columns from the table. Also removed the same from the search filters.
Made default order of table to be descending and sorted by updated date.
Converted some older JS files to Typescript.