[FIX] - Reporting and typing of vc publish job #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure factory is producing a datetime and not a date
i have no idea anymore
slow on startup with MDS being large. it might be indexing package files from other language
Jsyro
commented
Nov 15, 2024
| @@ -44,11 +47,11 @@ class PermitAmendment(SoftDeleteMixin, AuditMixin, Base): | |||
| permit_amendment_status_description = association_proxy('permit_amendment_status', | |||
| 'description') | |||
| permit_guid = association_proxy('permit', 'permit_guid') | |||
| permit_no = association_proxy('permit', 'permit_no') | |||
| permit_no: str = association_proxy('permit', 'permit_no') #type: ignore[reportAssignmentType] | |||
There was a problem hiding this comment.
This is for pylance, but i'm not sure about the details of this type hinting override.
simensma-fresh
previously approved these changes
Nov 18, 2024
|
simensma-fresh
approved these changes
Nov 18, 2024
taraepp
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.