Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-6206] Add support for custom permit condition categories #3318

Merged
merged 21 commits into from
Nov 28, 2024
Merged

[MDS-6206] Add support for custom permit condition categories #3318

merged 21 commits into from
Nov 28, 2024

Conversation

simensma-fresh
Copy link
Collaborator

@simensma-fresh simensma-fresh commented Nov 26, 2024 •
edited
Loading

Objective

MDS-6206

This PR adds functionality to allow for extracting, adding, editing, reordering, and deleting custom permit condition categories for Mines Act Permits. Also updated the permit condition extraction pipeline to add the conditions as is.

image

image

image

Extra

  • Enabled versioning and soft deletion of categories to capture history
  • Bumped up jest maxWorkers to 50% <-- reduced the time to run Minespace tests on my laptop from 1min 10s to 45s
  • Bumped version of actions/upload-artifact and actions/download-artifact in our Github Actions to v4 as v3 is being deprecated

@simensma-fresh simensma-fresh changed the title Mds 6206 permit condition categories MDS-6206 Add support for custom permit condition categories Nov 26, 2024
simensma-fresh
simensma-fresh commented Nov 26, 2024
View reviewed changes
cypress/realm-export.json Outdated
"c_idir",
"cs_mds_investigations",
"cs_mds_permit_template_conditions",
"Administrative Users",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bunch of roles that the cypress user didn't have

@simensma-fresh simensma-fresh changed the title MDS-6206 Add support for custom permit condition categories [MDS-6206] Add support for custom permit condition categories Nov 26, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@simensma-fresh simensma-fresh added 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💾 Backend This pull request includes backend changes. 💻 Frontend This pull request includes frontend changes. labels Nov 27, 2024
matbusby-fw
matbusby-fw requested changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That's a biggie! Just saw a couple of tiny things that can be removed, and one recommendation for changing how actions are fired in the one test. Otherwise this is awesome!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_common'

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

matbusby-fw
matbusby-fw approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦙

sggerard
sggerard approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@sggerard sggerard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🐟

@simensma-fresh simensma-fresh merged commit 1070b97 into develop Nov 28, 2024
16 of 17 checks passed
@simensma-fresh simensma-fresh deleted the MDS-6206_Permit-condition-categories branch November 28, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbusby-fw matbusby-fw matbusby-fw approved these changes

@sggerard sggerard sggerard approved these changes

@asinn134 asinn134 asinn134 approved these changes

@taraepp taraepp Awaiting requested review from taraepp

Assignees
No one assigned
Labels
💾 Backend This pull request includes backend changes. 💻 Frontend This pull request includes frontend changes. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simensma-fresh @matbusby-fw @asinn134 @sggerard