Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] - nullify mine_party_appt end_dates of 9999-12-31 #3324

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[FIX] - nullify mine_party_appt end_dates of 9999-12-31 #3324

merged 2 commits into from
Nov 28, 2024

Conversation

Jsyro
Copy link
Collaborator

@Jsyro Jsyro commented Nov 27, 2024

Ran in a transaction in TEST.

image

@Jsyro Jsyro added the 💊 Fix Fixes something that isn't working :) label Nov 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Jsyro Jsyro added 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. ⛏ Needs manual testing Indicates that the feature has not been validated or regression testing has not been complete. 📜 SQL This pull request contains database changes. labels Nov 27, 2024
simensma-fresh
simensma-fresh approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@simensma-fresh simensma-fresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💣

@Jsyro Jsyro merged commit c3b1deb into develop Nov 28, 2024
9 checks passed
@Jsyro Jsyro deleted the fix/mpa_end_date-9999 branch November 28, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbusby-fw matbusby-fw matbusby-fw approved these changes

@simensma-fresh simensma-fresh simensma-fresh approved these changes

Assignees
No one assigned
Labels
💊 Fix Fixes something that isn't working :) ⛏ Needs manual testing Indicates that the feature has not been validated or regression testing has not been complete. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 📜 SQL This pull request contains database changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jsyro @simensma-fresh @matbusby-fw