Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6273] Project file deletion #3343

Merged
merged 10 commits into from
Dec 17, 2024
Merged

[MDS-6273] Project file deletion #3343

merged 10 commits into from
Dec 17, 2024

Conversation

sggerard
Copy link
Collaborator

@sggerard sggerard commented Dec 12, 2024

Objective

Allow users when the application is still in draft status to delete documents on both the 'Purpose and Authorization' and 'Document Upload' tabs of the project application process in both CORE & Minespace.

MDS-6273

image

  • Added onDeleteDocument methods to both the AuthorizationsInvolved and DocumentUpload components.
  • When project is not in a draft status or edit mode then the delete option is not shown.
  • When a document is deleted a friendly message is shown, and the document is removed from the document table.
  • Updated the project summary delete document endpoint and tests to support amended documents
  • Minor change to project uploader to update existing files on file removal to fix the replace functionality.
  • Minor change to DocumentTable to remove mutating code.
  • Minor scss fix

asinn134
asinn134 previously approved these changes Dec 13, 2024
simensma-fresh
simensma-fresh previously approved these changes Dec 14, 2024
@taraepp taraepp dismissed stale reviews from simensma-fresh and asinn134 via 27fe718 December 16, 2024 18:32
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
54.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

Copy link

@sggerard sggerard added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Dec 17, 2024
@sggerard sggerard merged commit d81622d into develop Dec 17, 2024
18 of 19 checks passed
@sggerard sggerard deleted the 6273-project-file-removal branch December 17, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants