Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6304] Tighten up Archive/Replace docs for Major Mine Application #3352

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Dec 18, 2024

Objective

  • don't allow replace on spatial table
  • lock down actions on the form according to status instead of assuming they can't navigate to it
  • removed some unused imports
  • made a couple little tweaks to the document table...
    • I thought it would show Download instead of Actions so I added another condition to the logic to make it so
    • in order to put the header in a row with the Actions/Download button, passed it as a param
    • and then added spacing between the button and the table (on MS only. I seem to recall it already has spacing on CORE)

MDS-6304

Why are you making this change? Provide a short explanation and/or screenshots
image

@taraepp taraepp changed the title [MDS-6304] adjust allowed actions, and tweak document table to have things line … [MDS-6304] Tighten up Archive/Replace docs for Major Mine Application Dec 18, 2024
sggerard
sggerard previously approved these changes Dec 18, 2024
asinn134
asinn134 previously approved these changes Dec 18, 2024
Copy link
Collaborator

@simensma-fresh simensma-fresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a merge conflict, might have to re-generate that snap. Otherwise looks good!

@taraepp taraepp dismissed stale reviews from asinn134 and sggerard via 47e83e7 December 18, 2024 22:52
Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
71.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@taraepp taraepp requested review from sggerard and asinn134 December 19, 2024 17:23
@taraepp taraepp merged commit 72979bd into develop Dec 19, 2024
18 of 19 checks passed
@taraepp taraepp deleted the mds-6304-mma-bugs branch December 19, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants