Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6265] Project Summary: Change from Change Requested -> Under Review on final submit only #3353

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

simensma-fresh
Copy link
Collaborator

Objective

MDS-6265

Updated the Project Summary submission logic to change the status of the application from Change Requested to Under Review only when the declaration is re-submitted, not on updates on the other tabs.

Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So weird. This must have been lost in a rebase somewhere, but I added almost this exact logic already. 🤷🏻

currentTab === "declaration"
) {
// If a proponent re-submits the declaration, when changes are made to the project description,
// change it back to under review.
status_code = "UNR";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love for this business logic to live in the API instead so you can't get around it, but that's something for another time 🙃

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
12.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

@simensma-fresh simensma-fresh merged commit 0c89126 into develop Dec 19, 2024
16 checks passed
@simensma-fresh simensma-fresh deleted the MDS-6265_Fix-change-requested branch December 19, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants