Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6204] - condition review assignment #3355

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

matbusby-fw
Copy link
Collaborator

@matbusby-fw matbusby-fw commented Dec 19, 2024

Objective

MDS-6204

  • Added component to search for users
  • Added functionality to assign a user to a condition category
  • Can also remove an assignment (if you are the assignee or you have the correct role)
  • Locked editing of pemit conditions unless you are assigned as a reviewer
  • Included an update to the partySelect component to show a loading indicator when searching for a party (this was part of the early work before adding the user table, so I kept it)
image

@matbusby-fw matbusby-fw marked this pull request as ready for review December 20, 2024 16:51
@matbusby-fw matbusby-fw added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Dec 20, 2024
asinn134
asinn134 previously approved these changes Dec 20, 2024
Copy link
Collaborator

@asinn134 asinn134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
68.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

@matbusby-fw matbusby-fw merged commit 9e6145a into develop Dec 20, 2024
18 of 19 checks passed
@matbusby-fw matbusby-fw deleted the mds-6204-condition-review-assignment branch December 20, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants