Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6306] Fix minespace user mine management #3358

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

sggerard
Copy link
Collaborator

@sggerard sggerard commented Dec 27, 2024

Objective

MDS-6306

As a core Administrator, it is hard to edit a minespace user's list of mines due to the mine guid showing instead of the mine name. This is due to only the first 50 mines being returned by the api instead of the complete list which would cause a large slow response.

As an alternative solution, I have added all the mines that user's currently have assigned to the list so that they show correctly. Additionally I have converted files to typescript, fixed a bug where an update would trigger a call multiple times and sorted the list of mines.

Possible breaking changes:

  • Removed boolean from IOption as a boolean cannot be used as a key on a <select <option. This could have potential ramifications elsewhere. update: Have added IRadioOption as a replacement interface for the multiple implementations of RenderRatioButtons
  • Added IMineSearch and replaced IMine in MineReducer for mineNameList as search results appear to return a slightly different response to IMine. This is used in multiple places and could have ramifications elsewhere.

Copy link
Collaborator

@simensma-fresh simensma-fresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for more js->ts conversion!

@sggerard sggerard added 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💻 Frontend This pull request includes frontend changes. labels Jan 6, 2025
simensma-fresh
simensma-fresh previously approved these changes Jan 6, 2025
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarqubecloud bot commented Jan 6, 2025

Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
50.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sggerard sggerard requested review from taraepp and asinn134 January 6, 2025 22:42
@sggerard sggerard merged commit c68f189 into develop Jan 8, 2025
17 of 18 checks passed
@sggerard sggerard deleted the mds-6306-minespace-users branch January 8, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 Frontend This pull request includes frontend changes. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants