-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS-6306] Fix minespace user mine management #3358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay for more js->ts conversion!
Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'Issues Measures |
Quality Gate passed for 'bcgov-sonarcloud_mds_common'Issues Measures |
Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'Failed conditions |
Objective
MDS-6306
As a core Administrator, it is hard to edit a minespace user's list of mines due to the mine guid showing instead of the mine name. This is due to only the first 50 mines being returned by the api instead of the complete list which would cause a large slow response.
As an alternative solution, I have added all the mines that user's currently have assigned to the list so that they show correctly. Additionally I have converted files to typescript, fixed a bug where an update would trigger a call multiple times and sorted the list of mines.
Possible breaking changes: