Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6300] Update and fix ams related fields that are submitted #3360

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

asinn134
Copy link
Collaborator

@asinn134 asinn134 commented Jan 3, 2025

Objective

MDS-6300

-Adjusted payment contact address info to be required

-Fixed indexing error that occurs if previously submitted application did not have payment contact address info filled out and the user goes back to fill it out afterwards.

-Other then the above issues it was found the fields submitted are sent correctly to AMS. I have confirmed this with Dan from Computronix

Copy link

sonarqubecloud bot commented Jan 4, 2025

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarqubecloud bot commented Jan 4, 2025

Copy link

sonarqubecloud bot commented Jan 4, 2025

Copy link

sonarqubecloud bot commented Jan 4, 2025

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@asinn134 asinn134 marked this pull request as ready for review January 4, 2025 01:09
@asinn134 asinn134 added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants