[CHORE] Replace useDispatch/useSelector with useAppDispatch/useAppSelector #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taraepp
added
the
🚧 WIP
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I gave it a go! Unfortunately there are errors running the app that seem to be related to useSelector. I didn't try replacing them separately to investigate. Putting up a draft PR for greater visibility. I had no luck with regex but I did about 3 or 4 different find + replace that seemed to do the trick pretty quickly. Aaand now I see that I didn't have the "regex search" option turned on. 🤦♀️
There's also a couple of errors in tests, some that look like what I'm seeing above in my console, and some that are just because we're importing useSelector and mocking it (so the test probably needs some love in a couple cases but I wasn't going to bother with that right now when there's functional issues).