[MDS-6299] Add "Manage My Mines" dropdown to MinesPage UI #3362
Conversation
Introduce a dropdown menu on the MinesPage allowing users to request access to or removal from mines directly.
matbusby-fw
requested review from
simensma-fresh,
taraepp,
asinn134 and
sggerard
| ], | ||
| }} | ||
| > | ||
| <Button className="mine-page-dropdown">Manage My Mines</Button> |
There was a problem hiding this comment.
For consistency across similar elements, would recommend trying:
- make the dropdown button type primary
- mine-page-dropdown --> actions-dropdown-button
- for the item buttons, className="actions-dropdown-button menu-item-button fa-icon-container"
- I think you can use className="color-error" for the same effect as "mines-page-remove-mine-link"
The faIcons might make it so the spacing isn't quite right that way, but should help keep styles in line and then you don't have to fuss with some of the styling details that have already been handled. Not 100% sure that all those styles have been carried over from Core, but pretty sure.
There was a problem hiding this comment.
Yeah, nice suggestions. I had looked for something that had the error color but somehow missed that one. Good call on the actions-dropdown-button menu-item-button fa-icon-container. It's a good fit. Kind of what I hate about css though, that it depends on someone remembering where a certain class being reused would be appropriate. 🤷🏻
There was a problem hiding this comment.
I figured it would want to be the same as the actions menu button but yeah it's a total pain! Like, I do just remember at this point that we have color-x and bg-color-x rules for the main theme colours but it's not intuitive at all and then the scss setup makes it even harder to find because it's like .color { &-error}. Ahhh CSS...
|
Objective
MDS-