Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Update some theme colours #3382

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Jan 21, 2025

Objective

Separating out changes to colours into its own PR

  • Match mockups
  • changes in webpack.parts affect how index-pure.less is compiled so it gets those sneaky class attributes
  • generally I do like to use the color and bg-color class names instead of setting the style.color attribute, but I wanted to be absolutely sure I wasn't breaking anything.
  • ScrollSidePageWrapper had the linter or sonarqube (I forget which) yelling at me when I opened it to get rid of the unused import and the ternary, so I did that.

Screenshots

Note that some of the changes here, like the text change from Needs Review --> Requires Review, are not included in this PR (images are to show colour changes)
(left = after, right = before)
image
image
new red: #D8292F, old red: #DF0D0D (not really noticeable!)
New yellow:
image
Old yellow:
image

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

@taraepp taraepp merged commit 300f290 into develop Jan 21, 2025
17 checks passed
@taraepp taraepp deleted the mds-6174-show-now-extract-difference branch January 21, 2025 18:42
@taraepp taraepp restored the mds-6174-show-now-extract-difference branch January 21, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants