Sonar lint fixes

bcgov · Sep 15, 2024 · 53cf7f5 · 53cf7f5
1 parent 4992b85
commit 53cf7f5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/bcmi/src/app/app.component.html b/bcmi/src/app/app.component.html
@@ -187,7 +187,7 @@ <h4>Connect With Us</h4>
 					<a class="twitter-share-button" href="https://twitter.com/share" data-show-count="false" target="_blank" rel="noopener">
 						<img alt="twitter share" src="assets/images/twitter_circle.svg"/>
 					</a>
-					<script async src="//platform.twitter.com/widgets.js" charset="utf-8"></script>
+					<script src="https://platform.twitter.com/widgets.js" integrity="sha384-2tybKFlI8VO9WeecxiJMRsCpfm6xp0mNzAuAFOxtqzenagQgy+bKmARu8EXVJhPu" crossorigin="anonymous"></script>
 				</li>
 				<li>
 					<a href="https://plus.google.com/share?url=mines.nrs.gov.bc.ca"

diff --git a/bcmi/src/app/projects/project-detail/documents/documents-tab-content.component.html b/bcmi/src/app/projects/project-detail/documents/documents-tab-content.component.html
@@ -17,17 +17,17 @@
         <table class="table mb-0" aria-describedby="Other documents table header">
           <thead class="inspections-list__sort-header">
             <tr>
-              <th id="hdr-name" class="inspections-list__name-col sortable" (click)="sort('displayName')">Name
+              <th id="hdr-name" class="inspections-list__name-col sortable" (click)="sort('displayName')" (keydown)="sort('displayName')">Name
                 <i class="sort"
                   [ngClass]="{'sort-asc': (sortField === 'displayName' && sortAsc), 'sort-desc': (sortField === 'displayName' && !sortAsc) }"
                   aria-hidden="true"></i>
               </th>
-              <th id="hdr-agency" class="inspections-list__agency-col sortable" (click)="sort('agency')">Agency
+              <th id="hdr-agency" class="inspections-list__agency-col sortable" (click)="sort('agency')" (keydown)="sort('agency')">Agency
                 <i class="sort"
                   [ngClass]="{'sort-asc': (sortField === 'agency' && sortAsc), 'sort-desc': (sortField === 'agency' && !sortAsc) }"
                   aria-hidden="true"></i>
               </th>
-              <th id="hdr-date" class="inspections-list__date-col sortable" (click)="sort('date')">Date
+              <th id="hdr-date" class="inspections-list__date-col sortable" (click)="sort('date')" (keydown)="sort('date')" >Date
                 <i class="sort"
                   [ngClass]="{'sort-asc': (sortField === 'date' && sortAsc), 'sort-desc': (sortField === 'date' && !sortAsc) }"
                   aria-hidden="true"></i>

diff --git a/bcmi/src/assets/styles/components/leaflet-map.scss b/bcmi/src/assets/styles/components/leaflet-map.scss
@@ -241,7 +241,6 @@ $toggle-list-anim-duration: 0.2s;
 .popup-header {
     background: #036;
     position: relative;
-    font-size: 12px;
     align-items: flex-start;
     justify-content: space-between;
     display: flex;

diff --git a/bcmi/src/index.html b/bcmi/src/index.html
@@ -43,7 +43,7 @@
   </app-root>
 
   <!-- Typekit -->
-  <script src="https://use.typekit.net/xuv4guc.js"></script>
+  <script src="https://use.typekit.net/xuv4guc.js" integrity="sha384-YBCfSqS/y2ZkUUWvPQTliPn6MTq4BpQXuK5+XsezAGAb83A2PnY5DeqKRexfB/tB" crossorigin="anonymous"></script>
   <script>try{Typekit.load({ async: true });}catch(e){}</script>
 
 </body>