Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCMI-419] Fix partial routes and migrate some missing page content #421

Merged
merged 11 commits into from
Oct 11, 2024
Merged

[BCMI-419] Fix partial routes and migrate some missing page content #421

merged 11 commits into from
Oct 11, 2024

Conversation

raarielgrace
Copy link
Contributor

  • Added Enforcement Actions card and the buttons in the header to PageComponent
  • Fixed fragment handling on pages and altered the header buttons to use fragments
  • Added directive to turn relative hrefs into routerLinks and fragments
  • Removed static page routes

@raarielgrace raarielgrace linked an issue Oct 11, 2024 that may be closed by this pull request
Fix partial routes on BCMI website #419
Closed
@raarielgrace raarielgrace force-pushed the 419-fix-partial-routes-on-bcmi-website branch from 00b7f4d to edd5f35 Compare October 11, 2024 17:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

lunamoonmoon
lunamoonmoon approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@lunamoonmoon lunamoonmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enforcement actions card and header buttons work great with entries!

@raarielgrace raarielgrace merged commit c4a7f53 into BCMI-V2 Oct 11, 2024
5 checks passed
@raarielgrace raarielgrace deleted the 419-fix-partial-routes-on-bcmi-website branch October 11, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunamoonmoon lunamoonmoon lunamoonmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix partial routes on BCMI website
3 participants
@raarielgrace @lunamoonmoon @sggerard