Skip to content

Commit

Permalink
- app version = 5.2.13
Browse files Browse the repository at this point in the history
- fixed some xpro mappings
- deleted duplicate code lock
- added fallbacks in case FF isn't available
  • Loading branch information
severinbeauvais committed Oct 19, 2023
1 parent 69d7697 commit 1ef76f4
Show file tree
Hide file tree
Showing 6 changed files with 32 additions and 40 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.2.12",
"version": "5.2.13",
"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
7 changes: 0 additions & 7 deletions src/components/new-request/search.vue
Original file line number Diff line number Diff line change
Expand Up @@ -560,13 +560,6 @@ export default class Search extends Mixins(CommonMixin, NrAffiliationMixin, Sear
!this.isSupportedContinuationIn(this.getEntityTypeCd)
) return true
// Conditional for Continuation In Flow.
if (
this.isContinuationIn &&
this.isNumberedCompany &&
!this.isSupportedContinuationIn(this.getEntityTypeCd)
) return true
return false
}
Expand Down
2 changes: 1 addition & 1 deletion src/enums/entity-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ export enum EntityTypes {
RLC = CorpTypeCd.XPRO_LIMITED_LIABILITY_COMPANY,
XCP = CorpTypeCd.XPRO_COOP,
XCR = CorpTypeCd.XPRO_CORPORATION,
XL = CorpTypeCd.XPRO_LL_PARTNR,
XLL = CorpTypeCd.XPRO_LIMITED_LIABILITY_PARTNERSHIP,
XLP = CorpTypeCd.XPRO_LIMITED_PARTNERSHIP,
XL = CorpTypeCd.XPRO_LL_PARTNR,
XP = CorpTypeCd.XPRO_LIM_PARTNR,
XS = CorpTypeCd.XPRO_SOCIETY,
XSO = CorpTypeCd.XPRO_SOCIETY_NR,
Expand Down
35 changes: 17 additions & 18 deletions src/list-data/request-action-mapping.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,32 +61,31 @@ export const BcMapping: RequestActionMappingI = {

export const XproMapping: RequestActionMappingI = {
AML: [
EntityTypes.XCR,
EntityTypes.XCP
EntityTypes.XCP, // maps to Corp Type "XCP"
EntityTypes.XCR // maps to Corp Type "XCR"
],
ASSUMED: [
EntityTypes.XCR,
EntityTypes.RLC
EntityTypes.RLC, // maps to Corp Type "LLC"
EntityTypes.XCR // maps to Corp Type "XCR"
],
REN: [
EntityTypes.XCR,
EntityTypes.XCP,
EntityTypes.RLC
EntityTypes.RLC, // maps to Corp Type "LLC"
EntityTypes.XCP, // maps to Corp Type "XCP"
EntityTypes.XCR // maps to Corp Type "XCR"
],
REH: [
EntityTypes.A,
EntityTypes.LLC,
EntityTypes.XCP,
EntityTypes.XSO
EntityTypes.RLC, // maps to Corp Type "LLC"
EntityTypes.XCP, // maps to Corp Type "XCP"
EntityTypes.XSO, // maps to Corp Type "XS"
EntityTypes.XUL // maps to Corp Type "A"
],
CHG: [
EntityTypes.A,
EntityTypes.LLC,
EntityTypes.XCP,
EntityTypes.XL,
EntityTypes.XLL,
EntityTypes.XLP,
EntityTypes.XP
EntityTypes.RLC, // maps to Corp Type "LLC"
EntityTypes.XCP, // maps to Corp Type "XCP"
EntityTypes.XLL, // maps to Corp Type "XL"
EntityTypes.XLP, // maps to Corp Type "XP"
EntityTypes.XSO, // maps to Corp Type "XS"
EntityTypes.XUL // maps to Corp Type "A"
]
}

Expand Down
22 changes: 11 additions & 11 deletions src/mixins/common-mixin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,12 +156,6 @@ export class CommonMixin extends Vue {
return (nr?.priorityCd === PriorityCode.YES)
}

/** Returns true if the specified entity type is allowed for Incorporation / Registration. */
isSupportedIncorporationRegistration (type: EntityTypes): boolean {
const supportedEntites = GetFeatureFlag('supported-incorporation-registration-entities')
return supportedEntites.includes(type)
}

/**
* Returns true if society NRs are enabled -- in case societies NRs need to be released
* separately from the Way of Navigating feature changes.
Expand All @@ -179,33 +173,39 @@ export class CommonMixin extends Vue {
].includes(nr?.legalType)
}

/** Returns true if the specified entity type is allowed for incorporation / registration. */
isSupportedIncorporationRegistration (type: EntityTypes): boolean {
const supportedEntites = GetFeatureFlag('supported-incorporation-registration-entities') || []
return supportedEntites.includes(type)
}

/** Returns true if the specified request type is allowed for alteration (conversion). */
isSupportedAlteration (type: NrRequestTypeCodes): boolean {
const supportedAlterationTypes = GetFeatureFlag('supported-alteration-types')
const supportedAlterationTypes = GetFeatureFlag('supported-alteration-types') || []
return supportedAlterationTypes.includes(type)
}

/** Returns true if the specified entity type is allowed for amalgamation. */
isSupportedAmalgamation (type: EntityTypes): boolean {
const supportedAmalgamationEntities = GetFeatureFlag('supported-amalgamation-entities')
const supportedAmalgamationEntities = GetFeatureFlag('supported-amalgamation-entities') || []
return supportedAmalgamationEntities.includes(type)
}

/** Returns true if the specified entity type is allowed for name change. */
isSupportedChangeName (type: EntityTypes): boolean {
const supportedChangeNameEntities = GetFeatureFlag('supported-name-change-entities')
const supportedChangeNameEntities = GetFeatureFlag('supported-name-change-entities') || []
return supportedChangeNameEntities.includes(type)
}

/** Returns true if the specified entity type is allowed for continuation in. */
isSupportedContinuationIn (type: EntityTypes): boolean {
const supportedContInEntites = GetFeatureFlag('supported-continuation-in-entities')
const supportedContInEntites = GetFeatureFlag('supported-continuation-in-entities') || []
return supportedContInEntites.includes(type)
}

/** Returns true if the specified entity type is allowed for restoration/reinstatement. */
isSupportedRestoration (type: EntityTypes): boolean {
const supportedRestorationEntites = GetFeatureFlag('supported-restoration-entities')
const supportedRestorationEntites = GetFeatureFlag('supported-restoration-entities') || []
return supportedRestorationEntites.includes(type)
}

Expand Down

0 comments on commit 1ef76f4

Please sign in to comment.