18235 Fixed xpro mappings (#732)

* - app version = 5.2.13 - fixed some xpro mappings - deleted duplicate code lock - added fallbacks in case FF isn't available * - removed fallbacks - added default FF values
bcgov · Oct 19, 2023 · c502793 · c502793
1 parent 69d7697
commit c502793
Show file tree

Hide file tree

Showing 7 changed files with 39 additions and 41 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "name-request",
-  "version": "5.2.12",
+  "version": "5.2.13",
   "private": true,
   "appName": "Name Request UI",
   "sbcName": "SBC Common Components",

diff --git a/src/components/new-request/search.vue b/src/components/new-request/search.vue
@@ -560,13 +560,6 @@ export default class Search extends Mixins(CommonMixin, NrAffiliationMixin, Sear
       !this.isSupportedContinuationIn(this.getEntityTypeCd)
     ) return true
 
-    // Conditional for Continuation In Flow.
-    if (
-      this.isContinuationIn &&
-      this.isNumberedCompany &&
-      !this.isSupportedContinuationIn(this.getEntityTypeCd)
-    ) return true
-
     return false
   }
 

diff --git a/src/enums/entity-types.ts b/src/enums/entity-types.ts
@@ -30,9 +30,9 @@ export enum EntityTypes {
   RLC = CorpTypeCd.XPRO_LIMITED_LIABILITY_COMPANY,
   XCP = CorpTypeCd.XPRO_COOP,
   XCR = CorpTypeCd.XPRO_CORPORATION,
+  XL = CorpTypeCd.XPRO_LL_PARTNR,
   XLL = CorpTypeCd.XPRO_LIMITED_LIABILITY_PARTNERSHIP,
   XLP = CorpTypeCd.XPRO_LIMITED_PARTNERSHIP,
-  XL = CorpTypeCd.XPRO_LL_PARTNR,
   XP = CorpTypeCd.XPRO_LIM_PARTNR,
   XS = CorpTypeCd.XPRO_SOCIETY,
   XSO = CorpTypeCd.XPRO_SOCIETY_NR,

diff --git a/src/list-data/request-action-mapping.ts b/src/list-data/request-action-mapping.ts
@@ -61,32 +61,31 @@ export const BcMapping: RequestActionMappingI = {
 
 export const XproMapping: RequestActionMappingI = {
   AML: [
-    EntityTypes.XCR,
-    EntityTypes.XCP
+    EntityTypes.XCP, // maps to Corp Type "XCP"
+    EntityTypes.XCR // maps to Corp Type "XCR"
   ],
   ASSUMED: [
-    EntityTypes.XCR,
-    EntityTypes.RLC
+    EntityTypes.RLC, // maps to Corp Type "LLC"
+    EntityTypes.XCR // maps to Corp Type "XCR"
   ],
   REN: [
-    EntityTypes.XCR,
-    EntityTypes.XCP,
-    EntityTypes.RLC
+    EntityTypes.RLC, // maps to Corp Type "LLC"
+    EntityTypes.XCP, // maps to Corp Type "XCP"
+    EntityTypes.XCR // maps to Corp Type "XCR"
   ],
   REH: [
-    EntityTypes.A,
-    EntityTypes.LLC,
-    EntityTypes.XCP,
-    EntityTypes.XSO
+    EntityTypes.RLC, // maps to Corp Type "LLC"
+    EntityTypes.XCP, // maps to Corp Type "XCP"
+    EntityTypes.XSO, // maps to Corp Type "XS"
+    EntityTypes.XUL // maps to Corp Type "A"
   ],
   CHG: [
-    EntityTypes.A,
-    EntityTypes.LLC,
-    EntityTypes.XCP,
-    EntityTypes.XL,
-    EntityTypes.XLL,
-    EntityTypes.XLP,
-    EntityTypes.XP
+    EntityTypes.RLC, // maps to Corp Type "LLC"
+    EntityTypes.XCP, // maps to Corp Type "XCP"
+    EntityTypes.XLL, // maps to Corp Type "XL"
+    EntityTypes.XLP, // maps to Corp Type "XP"
+    EntityTypes.XSO, // maps to Corp Type "XS"
+    EntityTypes.XUL // maps to Corp Type "A"
   ]
 }
 

diff --git a/src/mixins/common-mixin.ts b/src/mixins/common-mixin.ts
@@ -156,12 +156,6 @@ export class CommonMixin extends Vue {
     return (nr?.priorityCd === PriorityCode.YES)
   }
 
-  /** Returns true if the specified entity type is allowed for Incorporation / Registration. */
-  isSupportedIncorporationRegistration (type: EntityTypes): boolean {
-    const supportedEntites = GetFeatureFlag('supported-incorporation-registration-entities')
-    return supportedEntites.includes(type)
-  }
-
   /**
    * Returns true if society NRs are enabled -- in case societies NRs need to be released
    * separately from the Way of Navigating feature changes.
@@ -179,6 +173,12 @@ export class CommonMixin extends Vue {
     ].includes(nr?.legalType)
   }
 
+  /** Returns true if the specified entity type is allowed for incorporation / registration. */
+  isSupportedIncorporationRegistration (type: EntityTypes): boolean {
+    const supportedEntites = GetFeatureFlag('supported-incorporation-registration-entities')
+    return supportedEntites.includes(type)
+  }
+
   /** Returns true if the specified request type is allowed for alteration (conversion). */
   isSupportedAlteration (type: NrRequestTypeCodes): boolean {
     const supportedAlterationTypes = GetFeatureFlag('supported-alteration-types')

diff --git a/src/plugins/featureFlags.ts b/src/plugins/featureFlags.ts
@@ -8,15 +8,21 @@ declare const window: any
  * Uses "namerequest" project (per LD client id in config).
  */
 const defaultFlagSet: LDFlagSet = {
-  'enable-priority-checkbox': false, // by default, priority is disabled
+  'banner-text': '', // by default, there is no banner text
   'disable-analysis': true, // by default, analysis is disabled
-  'hardcoded_regular_wait_time': 0, // by default, use actual wait time
+  'enable-genesys-web-message': false, // by default, genesys web message is disabled
+  'enable-priority-checkbox': false, // by default, priority is disabled
+  'enable-society': false, // by default society is disabled
+  'enable-web-chat': false, // by default, old webchat is disabled
   'hardcoded_priority_wait_time': 0, // by default, use actual wait time
+  'hardcoded_regular_wait_time': 0, // by default, use actual wait time
   'sentry-enable': false, // by default, no sentry logs
-  'banner-text': '', // by default, there is no banner text
-  'enable-web-chat': false, // by default, old webchat is disabled
-  'enable-genesys-web-message': false, // by default, genesys web message is disabled
-  'enable-society': false // by default society is disabled
+  'supported-alteration-types': [],
+  'supported-amalgamation-entities': [],
+  'supported-continuation-in-entities': [],
+  'supported-incorporation-registration-entities': [],
+  'supported-name-change-entities': [],
+  'supported-restoration-entities': []
 }
 
 /**