Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18205 Fixed incorrect entity types #730

Merged
merged 1 commit into from
Oct 17, 2023
Merged

18205 Fixed incorrect entity types #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.2.10",
"version": "5.2.11",
"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
10 changes: 5 additions & 5 deletions src/list-data/request-action-mapping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,22 +100,22 @@ export const BusinessLookupRequestActions = [
/** Entity types that require business lookup. */
export const BusinessLookupEntityTypes = [
EntityTypes.A,
EntityTypes.BC,
EntityTypes.BEN,
EntityTypes.BC, // Benefit Company
EntityTypes.BEN, // invalid?
Copy link
Collaborator Author

@severinbeauvais severinbeauvais Oct 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think BEN is invalid here but I'm not about to remove it in a hotfix without fully understanding how this list is used 😛

I also checked the other entries in this list, and I think they're OK, but there may be some types missing.

Copy link
Collaborator

@leodube-aot leodube-aot Oct 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree I had a brief look through namex and I don't believe BEN is valid, but it is probably not worth removing on a hotfix.

EntityTypes.C,
EntityTypes.CC,
EntityTypes.CCC,
EntityTypes.CUL,
EntityTypes.CP,
EntityTypes.CR,
EntityTypes.CR, // BC Limited Company
EntityTypes.FR, // Sole Proprietorship
Copy link
Collaborator Author

@severinbeauvais severinbeauvais Oct 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested FR by creating a name change NR for FM1056109 and verifying that corpnum was populated.

EntityTypes.GP,
EntityTypes.LLC,
EntityTypes.LP,
EntityTypes.PA,
EntityTypes.PAR,
EntityTypes.SO,
EntityTypes.SP,
EntityTypes.ULC,
EntityTypes.UL,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested UL by creating a name change NR for BC0871495 and verifying that corpnum was populated.

EntityTypes.XCP,
EntityTypes.XCR,
EntityTypes.XL,
Expand Down
Loading