Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23527 Changed a button label + updated README #778

Merged
merged 2 commits into from
Oct 18, 2024
Merged

23527 Changed a button label + updated README #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
288a847
- app version = 5.5.9
Oct 16, 2024
6989660
- revert lint change
Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
# Name Request Online Frontend
# Name Request UI

Copy link
Collaborator Author

@severinbeauvais severinbeauvais Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we always call it (and sometimes "Namerequest UI" as per the repo name).

We should not refer to "NRO" in the name.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarmitag Am I missing something here -- did the name actually change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I'm aware.

[![img](https://img.shields.io/badge/Lifecycle-Stable-97ca00)](https://github.com/bcgov/repomountie/blob/master/doc/lifecycle-badges.md)

## Project setup
```
npm install -g pnpm
pnpm install
```
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to look up how to use pnpm, so here I'm saving the next person a couple of minutes :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing happened to me a while ago. Good idea.


Expand Down
32 changes: 16 additions & 16 deletions app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.5.8",
"version": "5.5.9",
Copy link
Collaborator Author

@severinbeauvais severinbeauvais Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the version number.

I assume "pnpm" updated the other package versions.

Note that I did run the command npx update-browserslist-db@latest as recommended,

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package updates below should make no difference because (theoretically) the ^ instructed npm/node to use the latest minor/patch versions of the package, which is what the changes below do explicitly.

In other words, even though we asked for "compat-data v7.21.5", we were already using v7.24.4 due to the ^ symbol.

"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand All @@ -14,7 +14,7 @@
"build-check": "node --max_old_space_size=8000 node_modules/@vue/cli-service/bin/vue-cli-service.js build"
},
"dependencies": {
"@babel/compat-data": "^7.21.5",
"@babel/compat-data": "^7.24.4",
"@bcrs-shared-components/breadcrumb": "2.1.24",
"@bcrs-shared-components/corp-type-module": "1.0.15",
"@bcrs-shared-components/enums": "1.1.7",
Expand All @@ -23,18 +23,18 @@
"@bcrs-shared-components/interfaces": "1.0.67",
"@bcrs-shared-components/staff-payment": "1.0.29",
"@bcrs-shared-components/web-chat": "2.0.0",
"@mdi/font": "^4.5.95",
"@sentry/browser": "^7.49.0",
"@sentry/integrations": "^7.49.0",
"@mdi/font": "^4.9.95",
"@sentry/browser": "^7.110.1",
"@sentry/integrations": "^7.110.1",
"axios": "^0.27.2",
"babel-plugin-transform-decorators": "^6.24.1",
"core-js": "^3.30.1",
"core-js": "^3.37.0",
"http-status-codes": "^1.4.0",
"launchdarkly-js-client-sdk": "^2.24.2",
"lodash": "^4.17.21",
"qs": "^6.12.1",
"quill": "^2.0.0",
"remove-accents": "^0.4.2",
"remove-accents": "^0.4.4",
"sbc-common-components": "3.0.12",
"style-loader": "^1.3.0",
"tslib": "^2.6.2",
Expand All @@ -43,17 +43,17 @@
"vue-hotjar": "^1.4.0",
"vue-quill-editor": "^3.0.6",
"vue-router": "^3.6.5",
"vuetify": "^2.6.15",
"vuetify": "^2.7.2",
"vuex": "^3.6.2"
},
"devDependencies": {
"@babel/plugin-proposal-private-methods": "^7.18.6",
"@types/jest": "^27.5.2",
"@types/lodash": "^4.14.194",
"@types/lodash": "^4.17.0",
"@types/node": "^20.12.7",
"@types/sinon": "^10.0.14",
"@typescript-eslint/eslint-plugin": "^5.59.2",
"@typescript-eslint/parser": "^5.59.2",
"@types/sinon": "^10.0.20",
"@typescript-eslint/eslint-plugin": "^5.62.0",
"@typescript-eslint/parser": "^5.62.0",
"@volar-plugins/vetur": "latest",
"@vue/cli-plugin-babel": "^5.0.8",
"@vue/cli-plugin-eslint": "^5.0.8",
Expand All @@ -64,7 +64,7 @@
"@vue/cli-service": "^5.0.8",
"@vue/eslint-config-standard": "^4.0.0",
"@vue/eslint-config-typescript": "^9.1.0",
"@vue/test-utils": "^1.3.5",
"@vue/test-utils": "^1.3.6",
"@vue/vue2-jest": "^27.0.0",
"cross-env": "^7.0.3",
"eslint": "~7.32.0",
Expand All @@ -73,7 +73,7 @@
"json-server": "^0.15.1",
"postcss-loader": "^8.1.1",
"sass": "~1.32.13",
"sass-loader": "^10.4.1",
"sass-loader": "^10.5.2",
"sinon": "^14.0.2",
"ts-jest": "^27.1.5",
"typescript": "4.5.5",
Expand All @@ -82,10 +82,10 @@
"vue-debounce-decorator": "^1.0.1",
"vue-property-decorator": "^9.1.2",
"vue-template-compiler": "2.7.10",
"vuetify-loader": "^1.6.0",
"vuetify-loader": "^1.9.2",
"vuex-class": "^0.3.2",
"vuex-module-decorators": "^1.2.0",
"webpack": "5.78",
"webpack": "~5.78.0",
"webpack-bundle-analyzer": "^3.9.0"
},
"overrides": {
Expand Down
Loading
Loading