-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24107 Added designations for continued in business types #779
24107 Added designations for continued in business types #779
Conversation
- added designations for continued in business types (C, CBEN, CCC, CUL)
/gcbrun |
Temporary Url for review: https://namerequest-dev--pr-779-en1w3lo6.web.app
|
|
@@ -17,7 +17,7 @@ | |||
"@babel/compat-data": "^7.24.4", | |||
"@bcrs-shared-components/breadcrumb": "2.1.24", | |||
"@bcrs-shared-components/corp-type-module": "1.0.15", | |||
"@bcrs-shared-components/enums": "1.1.7", | |||
"@bcrs-shared-components/enums": "1.1.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to pull in the latest NR request type codes (as added in bcgov/entity#23382).
These codes are not used in Namerequest UI but it's good to keep things up to date.
@@ -27,6 +27,8 @@ const CooperativeDesignations: DesignationI = { | |||
|
|||
export const Designations = { | |||
BC: CorporateDesignations, | |||
C: CorporateDesignations, // continued in BC Limited Company |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C = same as CR (Corporation)
@@ -27,6 +27,8 @@ const CooperativeDesignations: DesignationI = { | |||
|
|||
export const Designations = { | |||
BC: CorporateDesignations, | |||
C: CorporateDesignations, // continued in BC Limited Company | |||
CBEN: CorporateDesignations, // continued in Benefit Company |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CBEN = same as BC (Benefit Company)
...CorporateDesignations.words | ||
], | ||
end: true | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CCC = same as CC
'UNLIMITED LIABILITY COMPANY' | ||
], | ||
end: true | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUL = same as UL
/gcbrun |
Temporary Url for review: https://namerequest-dev--pr-779-en1w3lo6.web.app |
This is ready for your review, and I'd love to get this merged and into Dev asap (to unblock further testing). Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #: bcgov/entity#24107
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).