Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24107 Added designations for continued in business types #779

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

severinbeauvais
Copy link
Collaborator

@severinbeauvais severinbeauvais commented Oct 29, 2024

Issue #: bcgov/entity#24107

Description of changes:

  • app version = 5.5.10
  • added designations for continued in business types (C, CBEN, CCC, CUL)
  • imported latest shared enums

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

- added designations for continued in business types (C, CBEN, CCC, CUL)
@severinbeauvais
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Oct 29, 2024

Temporary Url for review: https://namerequest-dev--pr-779-en1w3lo6.web.app

SB says: unfortunately this ^^ won't work because the Business Search API key isn't being populated in the preview site so business search won't work. (I asked Patrick to add the key to the GCP config.) See screenshots below instead. The key was present but the config to copy the key wasn't. Patrick showed me where it was. Works now!

@severinbeauvais
Copy link
Collaborator Author

Screenshots

Name Change - CCC
image

Name Change - ULC
image

Restore - C
image

Restore - CBEN
image

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Oct 29, 2024

Do not merge yet. I will update https://github.com/bcgov/bcrs-shared-components/blob/main/src/enums/name-request-codes.ts and import the latest enums package in Namerequest UI as part of this PR. Done!

@@ -17,7 +17,7 @@
"@babel/compat-data": "^7.24.4",
"@bcrs-shared-components/breadcrumb": "2.1.24",
"@bcrs-shared-components/corp-type-module": "1.0.15",
"@bcrs-shared-components/enums": "1.1.7",
"@bcrs-shared-components/enums": "1.1.13",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to pull in the latest NR request type codes (as added in bcgov/entity#23382).

These codes are not used in Namerequest UI but it's good to keep things up to date.

@@ -27,6 +27,8 @@ const CooperativeDesignations: DesignationI = {

export const Designations = {
BC: CorporateDesignations,
C: CorporateDesignations, // continued in BC Limited Company
Copy link
Collaborator Author

@severinbeauvais severinbeauvais Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C = same as CR (Corporation)

@@ -27,6 +27,8 @@ const CooperativeDesignations: DesignationI = {

export const Designations = {
BC: CorporateDesignations,
C: CorporateDesignations, // continued in BC Limited Company
CBEN: CorporateDesignations, // continued in Benefit Company
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CBEN = same as BC (Benefit Company)

...CorporateDesignations.words
],
end: true
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCC = same as CC

'UNLIMITED LIABILITY COMPANY'
],
end: true
},
Copy link
Collaborator Author

@severinbeauvais severinbeauvais Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUL = same as UL

@severinbeauvais
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namerequest-dev--pr-779-en1w3lo6.web.app

@severinbeauvais
Copy link
Collaborator Author

This is ready for your review, and I'd love to get this merged and into Dev asap (to unblock further testing). Thanks!

Copy link
Collaborator

@eve-git eve-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@severinbeauvais severinbeauvais merged commit d38a82e into bcgov:main Oct 29, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants