24190 Updated conversion codes + logic (WIP) #780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- imported latest shared enums - updated conversion enum keys - updated BEN conversion logic (WIP) - sorted Conversion Types list data - added BEN -> CCC conversion - updated online alteration logic
severinbeauvais
force-pushed
the
24190
branch
from
1a43068 to
f56dec3
Compare
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-780-u69ouaqx.web.app |
severinbeauvais
commented
Nov 6, 2024
| type === NrRequestTypeCodes.CONVERT_BC_TO_BEN || | ||
| type === NrRequestTypeCodes.CONVERT_BEN_TO_BC || | ||
| type === NrRequestTypeCodes.CONVERT_BEN_TO_CCC || | ||
| type === NrRequestTypeCodes.CONVERT_ULC_TO_BEN |
There was a problem hiding this comment.
This is the list of alterations for which we display a "contact us" message instead of an action button, "Alter Now".
This is the subject of bcgov/entity#24278.
Just leave this alone for now. (The change above is OK.)
|
Closing this PR in favour of #782 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#24190
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).