23332 - Enable request restoration NR for a limited restored company #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AimeeGao
requested review from
eve-git,
shaangill025,
stevenc987,
mengdong19,
ozamani9gh,
rarmitag,
flutistar and
EPortman
as code owners
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-786-fm9k04h2.web.app |
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-786-fm9k04h2.web.app |
EPortman
reviewed
Dec 19, 2024
AimeeGao
force-pushed
the
23332-request-restoration-NR-for-limited-restored-company
branch
from
0c906b2 to
471fae3
Compare
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-786-fm9k04h2.web.app |
meawong
pushed a commit
to meawong/namerequest
that referenced
this pull request
Jan 3, 2025
…cgov#786) * Added check for limited restoration * Added condition to use exact look up (BusinessFetch) component for restoration NRs
meawong
added a commit
that referenced
this pull request
Jan 3, 2025
* 25066-Update-allowable-BEN-conversions * 25066-Lint fixes * 25066-Use-namexservice-to-fetch-business * Add logic for displaying name change button * update patch version * Add feature flag check * lint fix * 24205 - updates for name change and alteration (#784) * 24205 - updates for name change and alteration ff * 24205 - remove feature flags * 24205 - remove feature flags * 24205 - update version * 24205 - remove unsused import * 24205 - remove consitional chaining * 24205 - update funstions * 24205 * 24205 * 24205- update mounted() with async * 24605 additional address field error when editing nr (#785) * 23332 - Enable request restoration NR for a limited restored company (#786) * Added check for limited restoration * Added condition to use exact look up (BusinessFetch) component for restoration NRs * 23332 - Fix request restoration nr for limited restored company (#787) * fix: allow historical businesses to request restoration NR * 24841 display error when create payment fails (#788) * 25066-Update-allowable-BEN-conversions * 25066-Lint fixes * 25066-Use-namexservice-to-fetch-business * 25066-Remove-unecessary-import * 25066-Remove fetch business service that is unused * 25066-Update patch version --------- Co-authored-by: ketaki-deodhar <[email protected]> Co-authored-by: EPortman <[email protected]> Co-authored-by: Aimee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#23332
Description of changes:
Updated
BusinessLookupFetchcomponent to use the exact lookup for restoration name requestsBusinessFetchcomponent for restoration NRsAdded check for limited restoration name requests
restorationExpiryDatebefore allowing the restoration NRScreenshots:
The user is not logged in:
Test locally with a limited restoration business:
BC0883802Select Reactivate a BC or Extraprovincial company, and put in the business identifier:
Click on the search button:
Test locally without a limited restoration business:
BC0883817Select Reactivate a BC or Extraprovincial company, put in the business identifier, and click on the search button:
Test locally with an expired limited restoration business:
BC0871585Select Reactivate a BC or Extraprovincial company, put in the business identifier, and click on the search button:
The user is logged in:
Test locally with a limited restoration business:
BC0883802Select Reactivate a BC or Extraprovincial company, and put in the business identifier:
Click on the search button:
Test locally without a limited restoration business:
BC0883817Select Reactivate a BC or Extraprovincial company, put in the business identifier, and click on the search button:
Test locally with an expired limited restoration business:
BC0871585Select Reactivate a BC or Extraprovincial company, put in the business identifier, and click on the search button:
Name Request Result:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).