WFPREV-100/101 SMK initialization & map interactions for project list #437
+2,017
−1,030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssylver93
force-pushed
the
WFPREV-100_1
branch
from
697d03e to
ba3c02a
Compare
yzlucas
reviewed
Jan 23, 2025
| rm -rf node_modules | ||
| yarn cache clean | ||
| npm cache clean --force |
There was a problem hiding this comment.
Why are we doing this? do you got yarn issue on sonar test build??
There was a problem hiding this comment.
Yes yarn was having issues finding lealfet dependencies for some reason. I changed to npm as I knew it was working for the other workflows, and didn't want to spend anymore time debugging.
yzlucas
reviewed
Jan 23, 2025
client/wfprev-war/src/main/angular/src/app/components/map/map.component.ts
Outdated
Show resolved
Hide resolved
yzlucas
reviewed
Jan 23, 2025
yzlucas
requested changes
Jan 23, 2025
|
yzlucas
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pins/cluster layer:
mocked polygons:
Pin change/polygons become darker when pin is clicked or project is selected on map: