Feature/angular update #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the node version from 14 to 20
…ecause it's not used.
vivid-esnauffer
had a problem deploying
to
DEV
GitHub Actions
Failure
vivid-esnauffer
had a problem deploying
to
DEV
GitHub Actions
Failure
vivid-esnauffer
had a problem deploying
to
DEV
GitHub Actions
Failure
vivid-esnauffer
had a problem deploying
to
DEV
GitHub Actions
Failure
vivid-esnauffer
had a problem deploying
to
DEV
GitHub Actions
Failure
vivid-esnauffer
had a problem deploying
to
DEV
GitHub Actions
Failure
mhostett
requested changes
Nov 27, 2024
...ras-underwriting-ngclient-lib/src/main/angular/projects/cirras-underwriting-api/package.json
Outdated
Show resolved
Hide resolved
cirras-underwriting-war/cirras-underwriting-war/src/main/angular/package.json
Outdated
Show resolved
Hide resolved
cirras-underwriting-war/cirras-underwriting-war/src/main/angular/src/app/app.module.ts
Show resolved
Hide resolved
| import {ServiceWorkerModule} from "@angular/service-worker"; | ||
| import {EffectsModule} from "@ngrx/effects"; | ||
| import {StoreModule} from "@ngrx/store"; | ||
| import {StoreDevtoolsModule} from "@ngrx/store-devtools"; | ||
| import {StoreRouterConnectingModule} from "@ngrx/router-store"; | ||
| import {AppConfigService, CoreUIModule, MapService, PublicApplicationHeaderModule, TokenService} from "@wf1/core-ui"; | ||
| import {AppConfigService, CoreUIModule, TokenService} from "@wf1/wfcc-core-lib"; //MapService, PublicApplicationHeaderModule, |
There was a problem hiding this comment.
Remove comment if possible?
| @@ -27,19 +27,22 @@ export class ForageDopFieldListComponent { | |||
|
|
|||
| setFieldHeaderStyles() { | |||
| return { | |||
| width: `${320 * this.numCuts + 1450}px` | |||
| //width: `${320 * this.numCuts + 1450}px` | |||
There was a problem hiding this comment.
Do we still need the commented out lines? lines 30, 37 and 44
| import {Moment} from "moment"; | ||
| import {SortDirection} from "@wf1/wfcc-core-lib"; | ||
| // import * as moment from "moment"; | ||
| // import {Moment} from "moment"; |
There was a problem hiding this comment.
Remove commented lines if possible
| @@ -1,6 +1,6 @@ | |||
| import {AbstractControl, ValidatorFn} from "@angular/forms"; | |||
| import * as moment from "moment"; | |||
|
|
|||
| // import * as moment from "moment"; | |||
There was a problem hiding this comment.
Remove commented line if possible
| @@ -69,7 +69,8 @@ import "wicg-inert"; //TODO add explanation | |||
|
|
|||
| if (!Element.prototype.matches) { | |||
| Element.prototype.matches = Element.prototype.msMatchesSelector || | |||
| Element.prototype.webkitMatchesSelector; | |||
| //Element.prototype.webkitMatchesSelector; // deprecated | |||
There was a problem hiding this comment.
Remove commented line if possible
| // box-shadow: 0px 3px 1px -2px rgba(0, 0, 0, 0.2), | ||
| // 0px 2px 2px 0px rgba(0, 0, 0, 0.14), | ||
| // 0px 1px 5px 0px rgba(0, 0, 0, 0.12) !important; | ||
| // } |
There was a problem hiding this comment.
Remove commented lines if possible
|
|
||
| // .mat-mdc-radio-button:not(.mat-radio-disabled).mat-accent.mat-radio-checked .mat-radio-outer-circle { | ||
| // border-color: $colour-blue; | ||
| // } |
There was a problem hiding this comment.
Remove commented lines if possible
…pdate/Delete - Backend
…olicy page were fixed. hideSingleSelectionIndicator removes the checkbox in the dropdown list.
vivid-esnauffer
had a problem deploying
to
DEV
GitHub Actions
Failure
…sert-Update-Delete-UI PIM-1721: Verified Grain - Harvested/Commodity Totals Grid - Insert/Update/Delete - Frontend
mhostett
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.