PIM-1847: Create User Settings View - Database #164
Merged
+75
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhostett
requested changes
Jan 3, 2025
|
|
||
| ALTER TABLE cuws.user_setting ADD CONSTRAINT fk_us_of | ||
| FOREIGN KEY (office_id) | ||
| REFERENCES cuws.office(office_id) ON DELETE RESTRICT ON UPDATE RESTRICT |
There was a problem hiding this comment.
ON DELETE RESTRICT ON UPDATE RESTRICT is not necessary. There are some triggers set in ER/Studio
| ; | ||
|
|
||
| CREATE INDEX ix_us_lug ON cuws.user_setting(login_user_guid) | ||
| TABLESPACE pg_default |
There was a problem hiding this comment.
Indexes for foreign keys insurance plan and office are missing
mhostett
requested changes
Jan 4, 2025
| CREATE INDEX ix_us_lug ON cuws.user_setting(login_user_guid) | ||
| TABLESPACE pg_default | ||
| ; | ||
| CREATE INDEX ix_us_psip ON cuws.user_setting(policy_search_insurance_plan_id) |
There was a problem hiding this comment.
We usually call the foreign key index the same as the foreign key besides the prefix (fk_ vs ix_)
So for these two it would be ix_us_ip and ix_us_of
mhostett
approved these changes
Jan 6, 2025
vivid-esnauffer
deleted the
feature/PIM-1847-Create-User-Settings-View-Database
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.