fix: CE-1059 Unable to save Decision section without entering all fields - incorrect toast #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added validation handling to prevent user from creating a decision with missing data, updated thunk to display correct toast
marqueone-ps
added
the
case_management_3
afwilcox
added
case_management_4
afwilcox
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Two additional functionality issues that seem to be here:
- You always get the error message toast regardless of if the save is successful or not.
- If you don't fully enter the action, today's date still shows up in the read only screen. I think there might be a fix for this in the branch CE-1059-natcom-changes but it might not be the most elegant way to resolve the problem
frontend/src/app/components/containers/complaints/outcomes/ceeb/ceeb-decision/decision-form.tsx
Outdated
Show resolved
Hide resolved
frontend/src/app/components/containers/complaints/outcomes/ceeb/ceeb-decision/decision-form.tsx
Outdated
Show resolved
Hide resolved
updates to validation to try and reduce cognitive complexity
|
afwilcox
approved these changes
Sep 17, 2024
|
Failing Cypress Test is due to a recent change in how the officer lists are populated. Will create a bug to address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unable to save Decision section without entering all fields - incorrect toast
Fixes # CE-1059
Tasks
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: