Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Equipment Codes #847

Open
wants to merge 12 commits into
base: release/0.6.12
Choose a base branch
from
Open

feat: New Equipment Codes #847

wants to merge 12 commits into from

Conversation

afwilcox
Copy link
Collaborator

@afwilcox afwilcox commented Jan 2, 2025

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Equipment Changes

  • Provides support for updated equipment codes
  • Only display active codes in drop down
  • Update equipment Set by labels to be more generic
  • K9 and Less Lethal methods do not require a removal date
  • Do not display K9 and less lethal methods as active

Outcome Changes

  • Provides support for updated outcome codes
  • Updated selector to determine if dropdown should display all options (Filters) or active options (New/Edit equipment)

Fixes #
CE-818
CE-1312

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Add New Equipment
  • Verify that Removal Information not required for K9 or Less Lethal Equipment
  • Verify Display is correct for various equipment types
  • Add New Outcome
  • Can find old 'Less Lethal' Outcomes but can't add new ones
  • Sort Order Correct
  • Old Values not showing

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@afwilcox afwilcox added the case_management_5 https://dc0a4a-compenf-dev-5-backend.apps.emerald.devops.gov.bc.ca/graphql label Jan 2, 2025
@dk-bcps
Copy link
Contributor

dk-bcps commented Jan 6, 2025

@afwilcox
One of the acceptance criteria is “K9 unit → Would not require a ‘removal’ for closing“. Does it mean a user should be able to close a complaint without specifying “Removed by” and “Removed date” for "K9 unit" equipment? If so, then this feature does not work. The app still shows an error message and does not allow closing the complaint. Same applies to “Less lethal” equipment type.
Screenshot 2025-01-06 at 12 20 47 PM

Same applies to “Less lethal” equipment type.

Screenshot 2025-01-06 at 12 20 00 PM

Copy link

sonarqubecloud bot commented Jan 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
case_management_5 https://dc0a4a-compenf-dev-5-backend.apps.emerald.devops.gov.bc.ca/graphql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants